[yocto] [meta-raspberrypi][PATCH v2] qtbase: enable Raspberry Pi support

[Jonathan Liu]

On 26/10/2015 7:08 PM, Paul Eggleton wrote:
> On Monday 26 October 2015 09:43:08 Jonathan Liu wrote:
>> [Support #16]
>>
>> Signed-off-by: Jonathan Liu <net147 at gmail.com>
>> ---
>>   recipes-qt/qt5/qtbase_%.bbappend | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>   create mode 100644 recipes-qt/qt5/qtbase_%.bbappend
>>
>> diff --git a/recipes-qt/qt5/qtbase_%.bbappend
>> b/recipes-qt/qt5/qtbase_%.bbappend new file mode 100644
>> index 0000000..3e5e667
>> --- /dev/null
>> +++ b/recipes-qt/qt5/qtbase_%.bbappend
>> @@ -0,0 +1,6 @@
>> +do_configure_prepend_rpi() {
>> +    cat > ${S}/mkspecs/oe-device-extra.pri << 'EOF'
>> +EGLFS_DEVICE_INTEGRATION = eglfs_brcm
>> +QMAKE_LIBS_EGL = -lEGL -lGLESv2
>> +EOF
>> +}
> I'm wondering if this is a good idea or not. I appreciate the intention, but
> does bbappending non-machine-specific recipes like this play well when you have
> other machines enabled in the same distro?
>
> Cheers,
> Paul
>
It would rebuild qtbase (and recipes depending on it) without Raspberry 
Pi support for other machines.
I see similar machine-specific do_configure_prepend elsewhere (e.g. 
https://github.com/Freescale/meta-fsl-arm/blob/master/qt5-layer/recipes-qt/qt5/qtbase_%25.bbappend).

Otavio, any thoughts on a better way to handle this?

Regards,
Jonathan