[yocto] [PATCH 10/10][auh] upgradehelper: Add support for generate buildhistory recipe diff's

[Paul Eggleton]

On Friday 31 July 2015 11:19:04 Aníbal Limón wrote:
> On 31/07/15 11:10, Paul Eggleton wrote:
> > On Friday 31 July 2015 10:39:37 Aníbal Limón wrote:
> >> Hi Paul,
> >> 
> >> On 31/07/15 10:29, Paul Eggleton wrote:
> >>> Hi Aníbal,
> >>> 
> >>> On Wednesday 29 July 2015 15:50:53 Aníbal Limón wrote:
> >>>> Now AUH generates buildhistory diff when recipe was upgraded
> >>>> successfully.
> >>>> 
> >>>> For enable this feature set into local.conf.
> >>>> 
> >>>> 	INHERIT += "buildhistory"
> >>>> 	BUILDHISTORY_COMMIT = "1"
> >>>> 
> >>>> Summary of the changes,
> >>>> 
> >>>> 	- bitbake.py: Enable environment generation without recipe,
> >>>> 	
> >>>>             removes Buildhistory class.
> >>>> 	
> >>>> 	- buildhistory.py: Add buildhistory class that generates initial
> >>>> 	
> >>>>             buildhistory revision and keeps track of build revisions
> >>>>             for
> >>>>             generate diff when build is successful.
> >>>>           
> >>>>           - upgradehelper.py: Add buildhistory steps for upgrade, add
> >>>>           
> >>>>             support for detect when buildhistory is enabled loading the
> >>>>             environment without recipe.
> >>> 
> >>> So this looks OK, but I can't tell if it ensures you get the difference
> >>> between successful builds rather than the difference to the last build -
> >>> we need to ensure that a failed build of a recipe in between isn't
> >>> considered as part of the comparison. In practice I guess this would
> >>> mean
> >>> storing the buildhistory revision of the last successful build for each
> >>> recipe.
> >> 
> >> I only made a diff if the build success in all machines this guarantee
> >> that only stores good information.
> > 
> > OK, I think I'm following now.
> > 
> > One other thing - I'm not particularly keen on the BB_ENV_EXTRAWHITE thing
> > - can you perhaps query the build system for the path it's using instead?
> I modified this env var to pass BUILDHISTORY_DIR variable per recipe
> this enables
> to save buildhistory into AUH workdir
> (build/upgrade-helper/work/recipe/buildhistory).

Yes, I understand that, I just think using BB_ENV_EXTRAWHITE to pass this in 
is a horrible hack and I'd rather not do it that way.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre