[yocto] [PATCH] bitbake: fetch2: Revalidate checksums, YOCTO #5571

[Clemens Lang]

Hi Alejandro,

On Thu, Feb 26, 2015 at 04:17:23PM -0600, Alejandro Hernandez wrote:
> This is the problem I see, I am not sure we want to import extra libraries
> here, as you state the use of pickle might be ok since it avoids the
> overhead of calculating the checksums each time, but I don't know if it is
> actually worth it, since checksums are calculated fairly quick anyway, this
> is my personal opinion, you may still submit it for review.

I don't think the use of cPickle is an issue here. It's already widely
used in other parts of the bitbake codebase. I agree one could just
re-compute the checkums every time, but that might take a while for
larger downloaded files, especially for SHA-256.

> And perhaps the reason it hasn't been reviewed is that I believe this
> patch should go to bitbake-devel at lists.openembedded.org instead.

I've re-sent the patch to bitbake-devel, thanks for the pointer.

> I also had this WIP branch on contrib, its from a couple of months
> back its "dirty" but in case you'd like to look around.
> 
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=hsalejandro/5571&id=2f59e26e534dc6b6d4c5bb8d78c574042e0fe7a7

Thanks, that was helpful in confirming that my approach isn't completely
unreasonable.


Clemens
-- 
Clemens Lang • Development Specialist
BMW Car IT GmbH • Lise-Meitner-Str. 14 • 89081 Ulm • http://bmw-carit.com
-------------------------------------------------------------------------
BMW Car IT GmbH
Geschäftsführer: Michael Würtenberger und Reinhard Stolle
Sitz und Registergericht: München HRB 134810
-------------------------------------------------------------------------