[yocto] [PATCH] Autobuilder.py: Fix triggered build bug

California Sullivan californialsullivan at gmail.com
Tue Sep 9 10:12:09 PDT 2014


I apologize for the late response - I was working through some other issues
that I wanted to make sure were unrelated to this.

I have tested this on a build that triggers a build on a remote worker, as
well as a build that triggers a build on a local worker. Both appear to
have full functionality.

---
Cal

On Tue, Sep 2, 2014 at 1:45 PM, Flanagan, Elizabeth <
elizabeth.flanagan at intel.com> wrote:

> On Thu, Aug 28, 2014 at 4:33 PM, California Sullivan
> <californialsullivan at gmail.com> wrote:
> > When a build was configured to use the TriggerBuilds build step, it would
> > take on the buildslave of the last triggered build rather than its own.
> >
> > Signed-off-by: California Sullivan <california.l.sullivan at intel.com>
> > ---
> >  lib/python2.7/site-packages/autobuilder/Autobuilder.py | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> > b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> > index a582a03..2e2e899 100644
> > --- a/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> > +++ b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> > @@ -58,7 +58,7 @@ class Autobuilder:
> >              self.set_props = {}
> >              self.repos = []
> >              self.properties = []
> > -            self.builders = None
> > +            self.builders = self.parseBuilders(buildset)
> >              self.schedprops.append(NestedParameter(name='ss_' +
> buildset,
> > label="<h3><div class='trigger_heading' id='"+buildset+"'>" + buildset +
> "
> > defaults:</div></h3>", fields=[FixedParameter(name="dummy",
> > default="dummy")]))
> >              self.parseBuildSet(buildset)
> >              locals()['buildset_%s' %
> > buildset]=BuildSet.BuildSet(name=buildset,
> > @@ -86,7 +86,6 @@ class Autobuilder:
> >
> >      def parseBuildSet(self, buildset):
> >          if buildset is not "BuildSets":
> > -            self.builders=self.parseBuilders(buildset)
> >              self.parseProps(buildset)
> >              self.parseRepos(buildset)
> >              self.parseSteps(buildset)
> > --
> > 1.9.1
> >
> >
> > --
> > _______________________________________________
> > yocto mailing list
> > yocto at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/yocto
> >
>
>
> This looks ok, but I'd like to test it a bit before I shove it into
> production. What have you tested this with (example: I tested it on a
> single build triggering another one, or a build that triggers
> itself...) With Trigger being a bit of core functionality, it would
> help a bit to know this.
>
> -b
>
>
> --
> Elizabeth Flanagan
> Yocto Project
> Build and Release
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/yocto/attachments/20140909/373049dd/attachment.html>


More information about the yocto mailing list