[yocto] [AB PATCH 00/27] Autobuilder patches

[Burton, Ross]

On 5 March 2014 18:22, Elizabeth Flanagan <elizabeth.flanagan at intel.com> wrote:
> Beth Flanagan (8):
>   PrepPkgIndex.py: ln instead of cp

This leaves several alternative lines that are commented out, why not
just have the one working line?

>   Autobuilder.py/Buildset.py: More sane parser/UI

Erm, yeah, sure.  I'll take your word for that :)

>   nightly.conf: Add additional parameters

This removes RunBitbakeSelfTest and needlessly reindents a large block.

Isn't the change to PublishLayerTarballs unrelated and therefore
should be in a separate commit?

>   CheckOutLayers.py/ResolveLayerHead.py: support simplified git

Ack.

>   Autobuilder.py: remove DEBUG code
>   BuildSet.py: Remove more debug code.
>   yocto-start/stop-autobuilder: start buildslave-janitor

Ack x 3.

>   forms.html/layout.html: support simplified UI

Ack.

> Elizabeth Flanagan (12):
>   nightly-world-uclibc: uclibc target

Ack.

>   SyncPersistDB.py: First run failure correction

Pretty sure you didn't mean -b there (block device).

>   BuildSet.py: Set workdir based on layer not order

I'm not massively keen on special-casing poky/oe-core like this
because it breaks when you use something that is almost but not quite
poky (such as iot-devkit).  Can this be an option that the buildset
can set (and defaulting to something that mostly works)?

Also a better idiom is:

if layername in ('poky', 'oe-core', 'eclipse'):
   pass

>   yoctogit.py: fix callbacks and instance attrs

More hardcoding of repo names and behaviour.  Again, does this mean
that iot-devkit (a fork of poky) won't build in the autobuilder?

>   PublishArtifacts.py: Fix poky-tiny publish
>   PublishArtifacts.py: genericx86-64 publish
>   BuildEclipsePlugin.py: Change location of build.
>   PublishArtifacts.py: Change where we find eclipse artifacts

Ack x 4

>   yocto-autobuilder-setup: set the correct bb version

Might be useful to stop using bb (bitbake? buildbot?) and use the full name :)

Ack.

>   fs.py: Bump default timeout

Ack.

>   autobuilder: whitespace removal
>   BuildSet.py: remove trailing spaces

Should be squashed.

> Richard Purdie (5):
>   Add mirror functionality to git fetcher
Ack.

>   trigger.py: Allow wait and nowait triggers

Ack.

>   yoctogit: Don't use branch args for referenced clone

This also changes os.path.exists to self.pathExists which AFAICT have
different uses (local vs remote).  The commit should clarify this.

>   bin/buildslave-janitor: For fast-git checkouts

Truncated commit message.

>   yoctogit: Remove use of oe.path.exists()

This commit doesn't actually remove a use of os.path.exists, so either
the patch is incomplete or the message is misleading.

> Stefan Stanacar (2):
>   buildsets: add a new buildset to run builds on target

Ack.

>   Add buildstep and buildset for oe-selftest script

I'm a big fan of logically independent sequential patches as they make
things a lot easier to review, so I'd say the change to CreateAutoConf
should be split out as a separate commit.  It's unrelated to the
commit short message and only mentioned in passing in the long
message.

Ross