[yocto] [PATCH 1/2] Send emails for a list of recipes

[Paul Eggleton]

Hi Marius,

On Thursday 21 August 2014 15:00:30 Marius Avram wrote:
> If the --emails or -e command line argument is active and a single
> or a list of recipes are given to the script, emails with the results
> and patches will be sent to their maintainers or to the overriden
> addresses from the configuration file.
> 
> Also the status email will be sent in the case a selection of
> at least two recipes has been given to the script for upgrading.
> 
> Signed-off-by: Marius Avram <marius.avram at intel.com>
> ---
>  upgradehelper.py |  199
> +++++++++++++++++++++++++++--------------------------- 1 file changed, 98
> insertions(+), 101 deletions(-)
> 
> diff --git a/upgradehelper.py b/upgradehelper.py
> index cc90958..771c981 100755
> --- a/upgradehelper.py
> +++ b/upgradehelper.py
> @@ -71,6 +71,8 @@ def parse_cmdline():
>                          help="disable interactive mode")
>      parser.add_argument("-d", "--debug-level", type=int, default=4,
> choices=range(1, 6), help="set the debug level: CRITICAL=1, ERROR=2,
> WARNING=3, INFO=4, DEBUG=5") 
> +    parser.add_argument("-e", "--emails", type=bool, default=False, 
> +                        help="send emails to recipe maintainers") 

Picky I know, but could you make the long option --send-emails?

> @@ -125,10 +147,10 @@ class Updater(object):
>          self.bb = Bitbake(get_build_dir())
>          self.buildhistory = BuildHistory(get_build_dir())
>          self.git = None
> -
> -        self.author = None
> +        self.author = "Upgrade Helper <uh at not.set>"

Does this mean that the author value is now forced to be this even if
I just want to upgrade a few recipes locally with the tool (and therefore
my own author info should be used)?

> -        if self.statistics.total_attempted:
> -            self.send_email(to_list, subject, msg)
> -        else:
> -            W("No recipes attempted, not sending status mail!")
> +        super(UniverUpdate, self).pkg_upgrade_handler(self)

Shouldn't this be UniverseUpdater?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre