[yocto] IMAGE_FEATURES check broken

[Gary Thomas]

On 2013-05-14 04:56, Martin Jansa wrote:
> On Tue, May 14, 2013 at 04:45:02AM -0600, Gary Thomas wrote:
>> This commit breaks systems where IMAGE_FEATURES includes "package-management":
>>
>> commit d63c8a1597c9bd0a838cb59ca461ac432b630a90
>> Author: Paul Eggleton <paul.eggleton at linux.intel.com>
>> Date:   Thu May 9 17:24:25 2013 +0100
>>
>>       classes/image: show an error on invalid IMAGE_FEATURES
>>
>> A quick look at that class shows that package-management is being left
>> out of the "validitems".  This patch fixes it:
>>
>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>> index 2b42e12..4f07708 100644
>> --- a/meta/classes/image.bbclass
>> +++ b/meta/classes/image.bbclass
>> @@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
>>    # IMAGE_FEATURES may contain any available package group
>>    IMAGE_FEATURES ?= ""
>>    IMAGE_FEATURES[type] = "list"
>> -IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
>> +IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs package-management"
>>
>>    # rootfs bootstrap install
>>    ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES", "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR
>>
>> Am I missing something else, or was this just overlooked?
>
> The same patch is already on oe-core ML where it belongs:
> http://lists.linuxtogo.org/pipermail/openembedded-core/2013-May/039541.html

Thanks (I missed that one because it happened late Sunday over here)

Note: I sent my email to this list because of the comment in the commit
which referred directly to a Yocto bug. ... I have a hard time figuring
out where Yocto ends and OE-core begins ...

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------