[yocto] [Refactor RFC 5/9] Remove storing of init script location

[Grigoropol, IoanaX]

Hi Jessica,

The reason I have remove this is that we can always find it on git.
So if we at some point decide that we need to save the location of the init script, we can just look in the git log, and add it again. 
I do not see the point in keeping classes, methods that are not used, and which at this point need to be fixed due to the changes I have introduced, otherwise they will not compile.

Thanks,
Ioana
________________________________________
From: Zhang, Jessica
Sent: Friday, June 07, 2013 3:02 AM
To: Grigoropol, IoanaX; yocto at yoctoproject.org
Subject: RE: [yocto] [Refactor RFC 5/9] Remove storing of init script location

Why we want to remove this project info file, since it's not used now but it stated it's used for future.

-----Original Message-----
From: yocto-bounces at yoctoproject.org [mailto:yocto-bounces at yoctoproject.org] On Behalf Of Ioana Grigoropol
Sent: Tuesday, June 04, 2013 6:26 AM
To: yocto at yoctoproject.org
Subject: [yocto] [Refactor RFC 5/9] Remove storing of init script location

- when create a new bitbake commander project and when initializing the configuration - the location of the init bitbake script is stored in a file called .eclipse-data
- the information stored here is never used

Signed-off-by: Ioana Grigoropol <ioanax.grigoropol at intel.com>
---
 .../org/yocto/bc/bitbake/ProjectInfoHelper.java    |   23 --------------------
 .../BBConfigurationInitializeOperation.java        |    1 -
 .../newproject/CreateBBCProjectOperation.java      |    6 -----
 3 files changed, 30 deletions(-)

diff --git a/plugins/org.yocto.bc.ui/src/org/yocto/bc/bitbake/ProjectInfoHelper.java b/plugins/org.yocto.bc.ui/src/org/yocto/bc/bitbake/ProjectInfoHelper.java
index 25dac97..b8d4b29 100644
--- a/plugins/org.yocto.bc.ui/src/org/yocto/bc/bitbake/ProjectInfoHelper.java
+++ b/plugins/org.yocto.bc.ui/src/org/yocto/bc/bitbake/ProjectInfoHelper.java
@@ -79,27 +79,4 @@ public class ProjectInfoHelper {

                return null;
        }
-
-       /**
-        * This method will store the path to the bitbake init script for future
-        * reference.
-        *
-        * @param path
-        * @param projInfo
-        * @throws IOException
-        */
-       public static void store(String path, ProjectInfo projInfo) throws IOException {
-               writeToFile(path, projInfo.getInitScriptPath());
-       }
-
-       private static void writeToFile(String path, String init) throws IOException {
-               File outFile = new File(path, ".eclipse-data");
-               FileOutputStream fos = new FileOutputStream(outFile);
-
-               fos.write(init.getBytes());
-
-               fos.flush();
-               fos.close();
-       }
-
 }
diff --git a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/newproject/BBConfigurationInitializeOperation.java b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/newproject/BBConfigurationInitializeOperation.java
index 4f15107..64c3e6e 100644
--- a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/newproject/BBConfigurationInitializeOperation.java
+++ b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/newproject/BBConfigurationInitializeOperation.java
@@ -39,7 +39,6 @@ public class BBConfigurationInitializeOperation implements IRunnableWithProgress
        public void run(IProgressMonitor monitor) throws InvocationTargetException, InterruptedException {
                BBSession session;
                try {
-                       ProjectInfoHelper.store(pinfo.getRootPath(), pinfo);
                        session = Activator.getBBSession(pinfo.getRootPath(), writer);
                        session.initialize();

diff --git a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/newproject/CreateBBCProjectOperation.java b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/newproject/CreateBBCProjectOperation.java
index dc0153b..1d54ea3 100644
--- a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/newproject/CreateBBCProjectOperation.java
+++ b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/newproject/CreateBBCProjectOperation.java
@@ -85,12 +85,6 @@ public class CreateBBCProjectOperation extends WorkspaceModifyOperation {

                IProject proj = wsroot.getProject(projInfo.getProjectName());
                proj.create(desc, monitor);
-               try {
-                       ProjectInfoHelper.store(proj.getLocationURI().getPath(), projInfo);
-               } catch (IOException e) {
-                       throw new InvocationTargetException(e);
-               }
-
                proj.open(monitor);

                addNatures(proj, monitor);
--
1.7.9.5

_______________________________________________
yocto mailing list
yocto at yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto