[yocto] [RFC Refactor 5/5] Validate project name to check for invalid characters

Ioana Grigoropol ioanax.grigoropol at intel.com
Thu Jun 6 05:47:35 PDT 2013


- project names should not allow spaces, or any illegal characters

Signed-off-by: Ioana Grigoropol <ioanax.grigoropol at intel.com>
---
 .../yocto/bc/ui/wizards/install/OptionsPage.java   |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
index 24fd94b..d9ba0ee 100644
--- a/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
+++ b/plugins/org.yocto.bc.ui/src/org/yocto/bc/ui/wizards/install/OptionsPage.java
@@ -179,10 +179,18 @@ public class OptionsPage extends FiniteStateWizardPage {
 	}
 
 	private boolean isValidProjectName(String projectName) {
-		if (projectName.indexOf('$') > -1) {
+		if (projectName.contains("\\s+"))
+			return false;
+
+		if (projectName.indexOf('$') != -1)
 			return false;
-		}
 
+		char[] chars = projectName.toCharArray();
+		if (!Character.isJavaIdentifierStart(chars[0]))
+			return false;
+		for (int i = 1; i < chars.length; i++)
+			if (!Character.isJavaIdentifierPart(chars[i]) && chars[i] != '-')
+				return false;
 		return true;
 	}
 
-- 
1.7.9.5




More information about the yocto mailing list