[yocto] [PATCH] Fix retrieval of System tap parameters

Ioana Grigoropol ioanax.grigoropol at intel.com
Fri Jul 5 03:42:28 PDT 2013


- the parameters for runnin crosstap are populated before the window is actually open so they remain null
	-> retrieve them after the window has closed & run the script

Signed-off-by: Ioana Grigoropol <ioanax.grigoropol at intel.com>
---
 .../sdk/remotetools/actions/SystemtapHandler.java  |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/actions/SystemtapHandler.java b/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/actions/SystemtapHandler.java
index 9d27e5a..184582a 100644
--- a/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/actions/SystemtapHandler.java
+++ b/plugins/org.yocto.sdk.remotetools/src/org/yocto/sdk/remotetools/actions/SystemtapHandler.java
@@ -33,13 +33,14 @@ public class SystemtapHandler extends AbstractHandler {
 				shell, "Systemtap"
 				);
 		
-		String metadata_location = ((SystemtapSettingDialog)setting).getMetadataLocation();
-		String remote_host = ((SystemtapSettingDialog)setting).getRemoteHost();
-		String user_id = ((SystemtapSettingDialog)setting).getUserID();
-		String systemtap_script = ((SystemtapSettingDialog)setting).getSystemtapScript();
-		String systemtap_args = ((SystemtapSettingDialog)setting).getSystemtapArgs();
 
 		if(setting.open() == BaseSettingDialog.OK) {
+
+			String metadata_location = ((SystemtapSettingDialog)setting).getMetadataLocation();
+			String remote_host = ((SystemtapSettingDialog)setting).getRemoteHost();
+			String user_id = ((SystemtapSettingDialog)setting).getUserID();
+			String systemtap_script = ((SystemtapSettingDialog)setting).getSystemtapScript();
+			String systemtap_args = ((SystemtapSettingDialog)setting).getSystemtapArgs();
 			IProgressService progressService = PlatformUI.getWorkbench().getProgressService();
 			SystemtapModel op = new SystemtapModel(metadata_location,remote_host, user_id, systemtap_script,
 					systemtap_args,window.getShell().getDisplay());
-- 
1.7.9.5




More information about the yocto mailing list