[yocto] [PATCH 4/5] plugins/sdk.ide: Removed validation from setCurrentInput

Timo Mueller mail at timomueller.eu
Wed Feb 27 06:37:15 PST 2013


From: Timo Mueller <timo.mueller at bmw-carit.de>

The result of the validation did not affect the behaviour of the
method. Also an error is not reported back to the caller or the
user. Validation of the setting should be handled before setting the
input or on save.

Signed-off-by: Timo Mueller <timo.mueller at bmw-carit.de>
---
 plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoUISetting.java | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoUISetting.java b/plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoUISetting.java
index 2affe82..ba80cb1 100644
--- a/plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoUISetting.java
+++ b/plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoUISetting.java
@@ -335,12 +335,6 @@ public class YoctoUISetting {
 		textKernelLoc.setText(elem.getStrQemuKernelLoc());
 		textQemuOption.setText(elem.getStrQemuOption());
 		textSysrootLoc.setText(elem.getStrSysrootLoc());
-
-		SDKCheckResults result = validateInput(SDKCheckRequestFrom.Preferences, false);
-		if (result != SDKCheckResults.SDK_PASS) {
-			System.out.println("Have you ever set Yocto Project Reference before?");
-			System.out.println(YoctoSDKChecker.getErrorMessage(result, SDKCheckRequestFrom.Other));
-		}
 	}
 
 	public SDKCheckResults validateInput(SDKCheckRequestFrom from, boolean showErrorDialog) {
-- 
1.7.11.7




More information about the yocto mailing list