[yocto] [meta-raspberrypi][PATCH] sdcard_image-rpi.bbclass: Allow optional compression

[Andrei Gherzan]

On Wed, Aug 21, 2013 at 11:12 PM, Paul Barker <paul at paulbarker.me.uk> wrote:

> On 20 August 2013 18:11, Andrei Gherzan <andrei at gherzan.ro> wrote:
> > On Fri, Aug 16, 2013 at 1:48 PM, Paul Barker <paul at paulbarker.me.uk>
> wrote:
> >>
> >> +# Compression method to apply to SDIMG after it has been created. May
> be
> >> "none",
> >> +# "gzip", "bzip2" or "xz". Setting this to something other than "none"
> >> will
> >> +# cause SDIMG to be renamed.
> >> +SDIMG_COMPRESSION ?= "none"
> >> +
> >
> >
> > One thing I don't understand here. Where is the SDIMG renamed if for
> example
> > I set by mistake SDIMG_COMPRESSION to something like
> "this-is-a-mistake"? If
> > I check your code this will be ignored as the case won't match any
> keywords.
> >
>
> Setting it to one of the other listed values will cause the SDIMG to
> be re-named. I think the code is as I intended, the documentation
> comment needs to be corrected though.
>
>
You are right. The comment confused me. So only if the COMPRESSION is "gzip",
"bzip2" or "xz" the SDIMG will be renamed. Understood now.

On the other hand, would it make sense to keep both uncompressed and
compressed images?


> Actually I could just have the default be an empty string as anything
> other than the understood compression types is ignored rather than
> treated as an error.
>
>
Indeed. Empty string would work without any issues.


>  > Would you mind adding the variable explanation to README too?
>
> Will do.
>
> I'll give this another spin this weekend.
>

Great. So all we need is a better comment, fix default value and a line or
two in readme.

Another idea. Would be a great feature to have a tool that would configure
the build interactively. Something like:

# configure-build
Want to have SD image compressed compressed? "y/n" y
What compression you want? "x/y/z" x
etc
etc

This script would just edit local.conf. This is because we defined a couple
of variables for this board - i would say pretty many (codecs keys, GPU,
mem etc etc) and it's pretty confusing for people who see this for the
first time. What do you think?

-- 
*Andrei Gherzan*
m: +40.744.478.414 |  f: +40.31.816.28.12
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/yocto/attachments/20130822/6a01a672/attachment.html>