[yocto] [meta-raspberrypi][PATCH] sdcard_image-rpi.bbclass: Allow optional compression

[Paul Barker]

On 20 August 2013 18:11, Andrei Gherzan <andrei at gherzan.ro> wrote:
> On Fri, Aug 16, 2013 at 1:48 PM, Paul Barker <paul at paulbarker.me.uk> wrote:
>>
>> +# Compression method to apply to SDIMG after it has been created. May be
>> "none",
>> +# "gzip", "bzip2" or "xz". Setting this to something other than "none"
>> will
>> +# cause SDIMG to be renamed.
>> +SDIMG_COMPRESSION ?= "none"
>> +
>
>
> One thing I don't understand here. Where is the SDIMG renamed if for example
> I set by mistake SDIMG_COMPRESSION to something like "this-is-a-mistake"? If
> I check your code this will be ignored as the case won't match any keywords.
>

Setting it to one of the other listed values will cause the SDIMG to
be re-named. I think the code is as I intended, the documentation
comment needs to be corrected though.

Actually I could just have the default be an empty string as anything
other than the understood compression types is ignored rather than
treated as an error.

> Would you mind adding the variable explanation to README too?

Will do.

I'll give this another spin this weekend.

-- 
Paul Barker

Email: paul at paulbarker.me.uk
http://www.paulbarker.me.uk