[yocto] [meta-raspberrypi][PATCH] sdcard_image-rpi.bbclass: Allow optional compression

[Andrei Gherzan]

On Fri, Aug 16, 2013 at 1:48 PM, Paul Barker <paul at paulbarker.me.uk> wrote:

> Image files will typically contain lots of null blocks and should compress
> well.
> This will help with distribution of images over slow network links.
>
> Signed-off-by: Paul Barker <paul at paulbarker.me.uk>
> ---
>  classes/sdcard_image-rpi.bbclass | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/classes/sdcard_image-rpi.bbclass
> b/classes/sdcard_image-rpi.bbclass
> index a2fcd52..8d2a5f2 100644
> --- a/classes/sdcard_image-rpi.bbclass
> +++ b/classes/sdcard_image-rpi.bbclass
> @@ -50,6 +50,11 @@ IMAGE_DEPENDS_rpi-sdimg = " \
>  # SD card image name
>  SDIMG = "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.rpi-sdimg"
>
> +# Compression method to apply to SDIMG after it has been created. May be
> "none",
> +# "gzip", "bzip2" or "xz". Setting this to something other than "none"
> will
> +# cause SDIMG to be renamed.
> +SDIMG_COMPRESSION ?= "none"
> +


One thing I don't understand here. Where is the SDIMG renamed if for
example I set by mistake SDIMG_COMPRESSION to something like
"this-is-a-mistake"? If I check your code this will be ignored as the case
won't match any keywords.

Would you mind adding the variable explanation to README too?

*Andrei Gherzan*
m: +40.744.478.414 |  f: +40.31.816.28.12
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/yocto/attachments/20130820/56df0908/attachment.html>