[yocto] [PATCHv3 09/10] plugins/sdk.ide: Improved usage of strings in class
Atanas Gegov
atanas.gegov.oss at gmail.com
Wed Apr 17 06:29:24 PDT 2013
From: Atanas Gegov <atanas.gegov at bmw-carit.de>
Extracted string constants. Added missing
NON-NLS-1 declarations.
---
.../NewYoctoAutotoolsProjectPostProcess.java | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/wizard/NewYoctoAutotoolsProjectPostProcess.java b/plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/wizard/NewYoctoAutotoolsProjectPostProcess.java
index 9bc042a..cb187e9 100644
--- a/plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/wizard/NewYoctoAutotoolsProjectPostProcess.java
+++ b/plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/wizard/NewYoctoAutotoolsProjectPostProcess.java
@@ -11,6 +11,7 @@
package org.yocto.sdk.ide.wizard;
import java.io.BufferedReader;
+import java.io.File;
import java.io.InputStream;
import java.io.InputStreamReader;
@@ -28,6 +29,9 @@ import org.yocto.sdk.ide.natures.YoctoSDKAutotoolsProjectNature;
public class NewYoctoAutotoolsProjectPostProcess extends ProcessRunner {
+ public static final String CHMOD_COMMAND = "chmod +x "; //$NON-NLS-1$
+ public static final String AUTOGEN_SCRIPT_NAME = "autogen.sh"; //$NON-NLS-1$
+
public NewYoctoAutotoolsProjectPostProcess() {}
public void process(TemplateCore template, ProcessArgument[] args, String processId, IProgressMonitor monitor) throws ProcessFailureException {
@@ -45,7 +49,7 @@ public class NewYoctoAutotoolsProjectPostProcess extends ProcessRunner {
} else {
IPath path = project.getLocation();
String path_str = path.toString();
- String autogen_cmd = "chmod +x " + path_str + "/autogen.sh";
+ String autogen_cmd = CHMOD_COMMAND + path_str + File.separator + AUTOGEN_SCRIPT_NAME;
try {
Runtime rt = Runtime.getRuntime();
Process proc = rt.exec(autogen_cmd);
@@ -53,7 +57,7 @@ public class NewYoctoAutotoolsProjectPostProcess extends ProcessRunner {
InputStreamReader isr = new InputStreamReader(stdin);
BufferedReader br = new BufferedReader(isr);
String line = null;
- String error_message = "";
+ String error_message = ""; //$NON-NLS-1$
while ( (line = br.readLine()) != null) {
error_message = error_message + line;
@@ -61,7 +65,7 @@ public class NewYoctoAutotoolsProjectPostProcess extends ProcessRunner {
int exitVal = proc.waitFor();
if (exitVal != 0) {
- throw new ProcessFailureException("Failed to make autogen.sh executable for project: " + projectName);
+ throw new ProcessFailureException("Failed to make autogen.sh executable for project: " + projectName); //$NON-NLS-1$
}
} catch (Throwable t) {
t.printStackTrace();
--
1.7.9.5
More information about the yocto
mailing list