[yocto] [PATCH 00/22][KERNEL][RFC] policy cleanup patches, v2

Bruce Ashfield bruce.ashfield at windriver.com
Mon May 14 08:22:30 PDT 2012


On 12-05-12 03:42 PM, tom.zanussi at intel.com wrote:
> From: Tom Zanussi<tom.zanussi at intel.com>
>
> This set of patches factors out the policy vs hardware-related config
> of the common-pc and common-pc-64 along with some meta-intel BSPs.
>
> There are also a couple usb cleanups as well.
>
> This is still an RFC patchset because it's completely untested at this
> point so shouldn't be pulled in yet.
>
> v2: updated to reflect Darren's comments.  This new patchset also
> adds the usb-mass-storage feature to common-pc and common-pc-64,
> and at the same time factors out the common SCSI pieces into a new
> set of scsi features.  It also removes options and feature use made
> redundant by the above changes.

I gave this a scan and it looks good to me. I've wanted to break out
scsi changes in the past, so the split looks like a good starting
point to me. Not knowing every option in the subsystem off by heart,
I like to explicitly include something that says "I need a scsi disk
or cdrom" .. so I like the clarify.

The USB cleanups look good with me.

Once we get this tested and in tree, I'll experiment with changing
some of the hardware/non-hardware designations to required/optional
naming and see what the audit subsystem has to say about it. But that's
orthogonal to this factoring and cleanup.

Cheers,

Bruce

>
> Tom
>
> The following changes since commit 1dfd60fa1250259eed38ae5b2840eb37e3758a1b:
>    Tom Zanussi (1):
>          meta/fishriver: move smp options from recipe-space
>
> are available in the git repository at:
>
>    git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/policy-cleanup
>    http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/policy-cleanup
>
> Tom Zanussi (22):
>    meta: add ROOT_HUB_TT config option to the usb/ehci-hcd feature
>    meta/common-pc: use usb features
>    meta/common-pc-64: use usb features
>    meta/common-pc: factor out policy-related options
>    meta/common-pc-64: factor out policy-related options
>    meta/crownbay: factor out policy-related options
>    meta/emenlow: factor out policy-related options
>    meta/fishriver: factor out policy-related options
>    meta/jasperforest: factor out policy-related options
>    meta/sugarbay: factor out policy-related options
>    meta: add scsi feature
>    meta: add scsi disk feature
>    meta: factor out SCSI options from the usb-mass-storage feature
>    meta/common-pc: use usb-mass-storage feature
>    meta: add scsi cdrom feature
>    meta/common-pc-64: use usb-mass-storage feature
>    meta/common-pc-64: factor out SCSI CDROM option
>    meta/jasperforest: remove redundant features and options
>    meta/sugarbay: remove redundant features and options
>    meta/crownbay: remove redundant features and options
>    meta/emenlow: remove redundant features and options
>    meta/fishriver: remove redundant features and options
>
>   .../bsp/common-pc-64/common-pc-64-preempt-rt.scc   |    7 +++++++
>   .../bsp/common-pc-64/common-pc-64-standard.scc     |    7 +++++++
>   .../kernel-cache/bsp/common-pc-64/common-pc-64.cfg |    8 --------
>   .../kernel-cache/bsp/common-pc-64/common-pc-64.scc |   10 ++++------
>   .../bsp/common-pc/common-pc-preempt-rt.scc         |    8 ++++++++
>   .../bsp/common-pc/common-pc-standard.scc           |    7 +++++++
>   .../kernel-cache/bsp/common-pc/common-pc-tiny.scc  |    5 +----
>   meta/cfg/kernel-cache/bsp/common-pc/common-pc.cfg  |    8 --------
>   meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc  |    7 +++----
>   .../bsp/crownbay/crownbay-preempt-rt.scc           |    8 ++++++++
>   .../bsp/crownbay/crownbay-standard.scc             |    7 +++++++
>   meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    1 -
>   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    8 --------
>   .../bsp/emenlow/emenlow-preempt-rt.scc             |    8 ++++++++
>   .../kernel-cache/bsp/emenlow/emenlow-standard.scc  |    8 ++++++++
>   meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg      |    1 -
>   meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc      |    8 --------
>   .../bsp/fishriver/fishriver-preempt-rt.scc         |    8 ++++++++
>   .../bsp/fishriver/fishriver-standard.scc           |    8 ++++++++
>   meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg  |    1 -
>   meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc  |    8 --------
>   .../bsp/jasperforest/jasperforest-preempt-rt.scc   |    4 ++++
>   .../bsp/jasperforest/jasperforest-standard.scc     |    3 +++
>   .../kernel-cache/bsp/jasperforest/jasperforest.cfg |    1 -
>   .../kernel-cache/bsp/jasperforest/jasperforest.scc |    8 --------
>   .../bsp/sugarbay/sugarbay-preempt-rt.scc           |    4 ++++
>   .../bsp/sugarbay/sugarbay-standard.scc             |    3 +++
>   meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg    |    1 -
>   meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc    |    8 --------
>   meta/cfg/kernel-cache/cfg/usb-mass-storage.cfg     |    2 --
>   meta/cfg/kernel-cache/cfg/usb-mass-storage.scc     |    2 ++
>   meta/cfg/kernel-cache/features/scsi/cdrom.cfg      |    1 +
>   meta/cfg/kernel-cache/features/scsi/cdrom.scc      |    6 ++++++
>   meta/cfg/kernel-cache/features/scsi/disk.cfg       |    1 +
>   meta/cfg/kernel-cache/features/scsi/disk.scc       |    6 ++++++
>   meta/cfg/kernel-cache/features/scsi/scsi.cfg       |    1 +
>   meta/cfg/kernel-cache/features/scsi/scsi.scc       |    4 ++++
>   meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg    |    1 +
>   38 files changed, 120 insertions(+), 77 deletions(-)
>   create mode 100644 meta/cfg/kernel-cache/features/scsi/cdrom.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/scsi/cdrom.scc
>   create mode 100644 meta/cfg/kernel-cache/features/scsi/disk.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/scsi/disk.scc
>   create mode 100644 meta/cfg/kernel-cache/features/scsi/scsi.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/scsi/scsi.scc
>




More information about the yocto mailing list