[yocto] [PATCH 1/1] local.conf.sample: add CONNECTIVITY_CHECK_URIS

[Joshua Lock]

On Wed, 2011-07-13 at 10:28 -0700, Darren Hart wrote:
> 
> On 07/12/2011 07:32 PM, Joshua Lock wrote:
> > Add CONNECTIVITY_CHECK_URIS to run the network connectivity sanity test for
> > http, https and git sources.
> > 
> > Signed-off-by: Joshua Lock <josh at linux.intel.com>
> > ---
> >  meta-yocto/conf/local.conf.sample |    8 ++++++++
> >  1 files changed, 8 insertions(+), 0 deletions(-)
> > 
> > diff --git a/meta-yocto/conf/local.conf.sample b/meta-yocto/conf/local.conf.sample
> > index ea32b81..fb20f2c 100644
> > --- a/meta-yocto/conf/local.conf.sample
> > +++ b/meta-yocto/conf/local.conf.sample
> > @@ -214,3 +214,11 @@ NO32LIBS = "1"
> >  # The network based PR service host and port
> >  #PRSERV_HOST = "localhost"
> >  #PRSERV_PORT = "8585"
> > +
> > +# Use the following URI's to test whether we can succesfully fetch from the
> > +# network (and warn you if not). This test will be run each time a new build
> > +# directory is specfied, if you wish to disable it delete or comment out the
> > +# following few lines that define CONNECTIVITY_CHECK_URIS.
> > +CONNECTIVITY_CHECK_URIS = "git://git.yoctoproject.org/yocto-firewall-test;protocol=git;rev=HEAD \
> > +			   https://eula-downloads.yoctoproject.org/index.php \
> > +			   http://bugzilla.yoctoproject.org/report.cgi"
> 
> 
> Would this not be better in a distro config file? conf/distro/poky.conf
> comes to mind.
> 
> Josh pointed out that the lsb variant would then miss out - so perhaps a
> network-sanity.inc file could be included by each distro defined in a
> layer. It doesn't make sense in layer.conf as multiple layers can be
> used - but as I understand it, only a single distro is built at a time?

I was being stupid both when I submitted this patch and when we
discussed it, the poky.conf file is inherited by each of the
distributions in meta-yocto so it makes sense to define this variable
there.

> 
> I like the idea of it working by default without any requirements on
> local.conf. The user could override this variable in local.conf if they
> want, but I don't think it should be required to be there for the checks
> to work.
> 

You are entirely correct. I should also set it with ?= so it's easy to
override.

v2 patch imminent.

Thanks,
Joshua
-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre