[yocto-ab] YP Advisory Board: VOTE meta-st-stm32mp (thud)

[akuster]

Yes from MontaVista



On 3/13/19 6:56 AM, Nicolas Dechesne wrote:
> Khem, Armin,
>
> many thanks for the additional review!
>
> Sebastien: thanks for the quick turnaround!
>
> I have executed the yocto-check-layer on the updated branch, and it
> still passes. It's interesting to note that it didn't catch the bison
> nativesdk issue, that will need to be investigated.
>
> Can I ask everyone for a vote again?
>
> cheers
> nico 
>
> On Wed, Mar 13, 2019 at 3:15 AM Sebastien GANDON
> <sebastien.gandon at st.com <mailto:sebastien.gandon at st.com>> wrote:
>
>     Hi there,
>
>     We have just pushed on top of the branch thud 3 commits which take
>     into account your remarks:
>
>     (df5efc60) README: update readme
>          Information updated:
>         - layers dependencies
>         - EULA
>         - contribution
>         - maintainers
>     (11c00b65) CONF: add more layer dependencies
>     (a0fa2e064) BISON: remove unnecessary patch
>         A new patch is already present on thud branch which
>         correct the issue with usage bison on sdk:
>         nativesdk-bison: Add to nativesdk-packagegroup-sdk-host and
>     set BISON_PKGDATADIR
>         SHA1 ID: 8aa27e4eb2f08281329ca1a1da421c6fc376bc8d
>
>
>     regards,
>     Sebastien
>     ________________________________________
>     From: yocto-ab-bounces at yoctoproject.org
>     <mailto:yocto-ab-bounces at yoctoproject.org>
>     <yocto-ab-bounces at yoctoproject.org
>     <mailto:yocto-ab-bounces at yoctoproject.org>> on behalf of akuster
>     <akuster at mvista.com <mailto:akuster at mvista.com>>
>     Sent: Wednesday, March 13, 2019 06:08
>     To: Khem Raj; Nicolas Dechesne
>     Cc: yocto-ab
>     Subject: Re: [yocto-ab] YP Advisory Board: VOTE meta-st-stm32mp (thud)
>
>     On 3/12/19 9:34 PM, Khem Raj wrote:
>     > On Tue, Mar 12, 2019 at 5:50 PM Nicolas Dechesne
>     > <nicolas.dechesne at linaro.org
>     <mailto:nicolas.dechesne at linaro.org>> wrote:
>     >> Hi there,
>     >>
>     >> STM has submitted a new layer for YP Compatible program, for thud.
>     >>
>     >> https://github.com/STMicroelectronics/meta-st-stm32mp
>     >>
>     https://layers.openembedded.org/layerindex/branch/thud/layer/meta-st-stm32mp/
>     >>
>     >> I have reviewed their application, and tested against the
>     >> yocto-check-layer, and it all looks good.
>     >>
>     >> Can you please vote yes/no?
>     >>
>     I would like to see a Maintainer and where to send patches in the
>     README.
>
>     This is on my top my list on needing to be in a README, for that I
>     vote
>     "No" until corrected.
>
>
>     I think its missing the from the layer.conf file:
>     LAYERDEPENDS_stm-st-stm32mp = "openembedded-layer", its listed in
>     the README
>
>     and maybe
>     LAYERDEPENDS_stm-st-stm32mp = "core" for completeness.
>
>     Just from a standardization point of view, the README is missing the
>     "bitbake" repo info, or they could have used Poky or both.
>
>
>     Just for clarity for the user. I see an EULA being included but I
>     don't
>     see it being explained what to do with it and its not mentioned in the
>     README.
>
>     May want to review:
>     regards,
>     Armin
>     > Readme points to invalid location
>     > https://github.com/openembedded/oe-core
>     >
>     > it does not list which layers under meta-openembedded repo it
>     depends
>     > on
>     >
>     >
>     https://github.com/STMicroelectronics/meta-st-stm32mp/blob/thud/recipes-devtools/bison/bison_%25.bbappend
>     >
>     > changes for all nativesdk
>     >
>     >
>     >
>     >> thanks!
>     >> nico
>     >> --
>     >> _______________________________________________
>     >> yocto-ab mailing list
>     >> yocto-ab at yoctoproject.org <mailto:yocto-ab at yoctoproject.org>
>     >> https://lists.yoctoproject.org/listinfo/yocto-ab
>
>
>     --
>     _______________________________________________
>     yocto-ab mailing list
>     yocto-ab at yoctoproject.org <mailto:yocto-ab at yoctoproject.org>
>     https://lists.yoctoproject.org/listinfo/yocto-ab
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/yocto-ab/attachments/20190313/a63c073c/attachment.html>