[poky] RFC: create-pull-request / send-pull-request updates

Koen Kooi koen at dominion.thruhere.net
Wed May 11 09:22:59 PDT 2011


Op 11 mei 2011, om 18:15 heeft Darren Hart het volgende geschreven:

> Between myself and others, there are several outstanding proposals to
> modify the pull-request scripts. Patches have been sent, but nothing has
> been merged due to a lack of consensus. I thought I would summarize what
> I see to be the current weaknesses of the scripts and my proposal to
> address them. I would like your feedback to ensure we have tools that
> meet the needs of a broad user base. Once we agree, I'll be happy to
> write up the patches or help review those written by others.
> 
> 1) send-pull-request is too aggressive with the auto-cc feature (Khem
>   Raj)
> 
>   One of the reasons I wrote these scripts was out of frustration with
>   git-send-email which allowed for a cover letter, but didn't include
>   all the collected addresses on it. The current script sends every
>   message to all the collected addresses. Khem (and others) have found
>   this behavior to be sub-optimal, if not down right annoying.
> 
>   I propose it be modified to only use the addresses local to each
>   patch for the patches and all the collected addresses only for the
>   cover letter.
> 
>   a) Do people agree with this policy? If not, and people prefer the
>      cover-letter only be sent to the recipients specified on the
>      command line, then this script doesn't add any real value over
>      'git request-pull' and 'git send-email', and users can easily
>      wrap those on their own.

Correct me if I'm wrong, but the current script pick up address from the patches inside the patches as well. The CC: list should only contain the "OE" people involved, not random kernel hackers mentioning in the patches.

regards,

Koen


More information about the poky mailing list