[poky] [PATCH 2/3] u-boot: add LIC_FILES_CHKSUM

[Gary Thomas]

On 02/09/2011 10:38 AM, Darren Hart wrote:
> On 02/08/2011 12:26 PM, Ilya Yanok wrote:
>> Signed-off-by: Ilya Yanok<yanok at emcraft.com>
>> ---
>> meta/recipes-bsp/uboot/u-boot.inc | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/recipes-bsp/uboot/u-boot.inc b/meta/recipes-bsp/uboot/u-boot.inc
>> index 889f621..6492016 100644
>> --- a/meta/recipes-bsp/uboot/u-boot.inc
>> +++ b/meta/recipes-bsp/uboot/u-boot.inc
>> @@ -5,6 +5,8 @@ PRIORITY = "optional"
>> LICENSE = "GPL"
>> PROVIDES = "virtual/bootloader"
>>
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb"
>> +
>
>  From what I can tell u-boot.inc is only used by u-boot_git.bb which already defines LIC_FILES_CHKSUM and the appropriate GPLv2+ LICENSE variable.
>
> It seems to me the LICENSE and LIC_FILES_CHKSUM should be defined in the same recipe as the SRC_URI. In this case, u-boot_git.bb. Is there a motivating reason to add it to .inc? If
> so, we should also remove it from u-boot_git.bb to avoid unnecessary duplication which leads to confusion down the road.
>

I agree - what if you have multiple .bb files sharing a single
.inc and the license and/or license data are different?  It
seems to me that this data should live where the actual sources
are being introduced, e.g. the .bb file.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------