[poky] [PATCH 05/12] qt4-tools-native: update from OpenEmbedded

Richard Purdie richard.purdie at linuxfoundation.org
Thu Feb 3 01:13:38 PST 2011


On Thu, 2011-02-03 at 02:58 +0000, Paul Eggleton wrote:
> On Tuesday 01 February 2011 17:44:12 you wrote:
> > Please don't reindent files when making other changes, it makes it hard
> > to see where the real changes were. I've pulled things but taken out the
> > worst whitespace changes manually this time.
> 
> A lot of those changes were brought in from meta-oe, although I admit I added 
> a fair few others. I will endeavour to keep indentation changes (if any) 
> separate in future.
>  
> > Please keep in mind:
> > 
> > shell functions/code use tabs
> > python code uses four space indentation
> 
> Is there a particular reason for this? Can we not use four spaces everywhere? 
> I see a wiki document that spells this out [1] however if it's of any 
> consequence, OE's documentation specifies spaces only [2].

Hmm, OE always used to be tabs for shell functions :/.

"it is a policy decision of OE that spaces always be used." - that is
news to me.

Ideally Yocto and OE need to be consistent. Something to table for
discussion with the TSC when we establish a new one I guess...

Cheers,

Richard

> Cheers,
> Paul
> 
> [1] 
> https://wiki.pokylinux.org/wiki/Best_Known_Methods_%28BKMs%29_for_Package_Updating#White_Space_Management
> 
> [2] http://docs.openembedded.org/usermanual/html/recipes_syntax.html
> _______________________________________________
> poky mailing list
> poky at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
> 





More information about the poky mailing list