[poky] [PATCH 05/12] qt4-tools-native: update from OpenEmbedded

Koen Kooi koen at dominion.thruhere.net
Tue Feb 1 10:02:43 PST 2011


Op 1 feb 2011, om 18:44 heeft Richard Purdie het volgende geschreven:

> On Sat, 2011-01-29 at 02:30 +0000, Paul Eggleton wrote:
>> @@ -30,7 +38,7 @@ EXTRA_OECONF = "-prefix ${prefix} \
>> EXTRA_OEMAKE = " "
>> 
>> do_configure() {
>> -	(echo o; echo yes) | ./configure ${EXTRA_OECONF} || die "Configuring qt failed. EXTRA_OECONF was ${EXTRA_OECONF}"
>> +   (echo o; echo yes) | ./configure ${EXTRA_OECONF} || die "Configuring qt failed. EXTRA_OECONF was ${EXTRA_OECONF}"
>> }
>> 
>> TOBUILD = "\
>> @@ -48,22 +56,22 @@ TOBUILD = "\
>> "
>> 
>> do_compile() {
>> -	for i in ${TOBUILD}; do
>> -		cd ${S}/$i && oe_runmake CC="${CC}" CXX="${CXX}"
>> -	done
>> +    for i in ${TOBUILD}; do
>> +        cd ${S}/$i && oe_runmake CC="${CC}" CXX="${CXX}"
>> +    done
>> }
> 
> 
> Please don't reindent files when making other changes, it makes it hard
> to see where the real changes were. I've pulled things but taken out the
> worst whitespace changes manually this time.

There were huge whitespace differences between the code in OE and the one in yocto, which made diffing really difficult. I ran into this when doing qt in meta-oe. I'll resync that with the current yocto tree when I get some time.

regards,

Koen


More information about the poky mailing list