[poky] [RFC][PATCH] RDEPENDS, RRECOMMENDS -> RDPEPENDS_${PN}, RRECOMMENDS_${PN}

[Richard Purdie]

On Thu, 2010-12-23 at 15:34 +0100, Koen Kooi wrote:
> Op 23 dec 2010, om 15:09 heeft Richard Purdie het volgende geschreven:
> 
> > On Thu, 2010-12-23 at 14:45 +0100, Koen Kooi wrote:
> >> diff --git a/meta/recipes-connectivity/avahi/avahi.inc b/meta/recipes-connectivity/avahi/avahi.inc
> >> index b266ea4..5c3b4dd 100644
> >> --- a/meta/recipes-connectivity/avahi/avahi.inc
> >> +++ b/meta/recipes-connectivity/avahi/avahi.inc
> >> @@ -16,7 +16,7 @@ PRIORITY = "optional"
> >> LICENSE = "GPLv2+ & LGPLv2.1+"
> >> 
> >> DEPENDS = "expat libcap libdaemon dbus glib-2.0 gtk+ libglade"
> >> -RRECOMMENDS = "libnss-mdns"
> >> +RRECOMMENDS_${PN} = "libnss-mdns"
> >> RRECOMMENDS_avahi-daemon = "libnss-mdns"
> > 
> > Hmm, which bit of avahi needs this? This looks a little odd...
> 
> It's an nss plugin, I install it so ssh can resolve .local addresses, not sure if avahi actually needs it. Any suggestions?

I've left the patch as is for now, I think this is perhaps correct as it
ensures the name resolution is available for both the client lib and the
daemon.

> > diff --git a/meta/recipes-connectivity/gsm/gsmd.inc b/meta/recipes-connectivity/gsm/gsmd.inc
> >> index 9818188..385c40e 100644
> >> --- a/meta/recipes-connectivity/gsm/gsmd.inc
> >> +++ b/meta/recipes-connectivity/gsm/gsmd.inc
> >> @@ -19,7 +19,7 @@ SRC_URI = "svn://svn.openmoko.org/trunk/src/target;module=gsm;proto=http \
> >> S = "${WORKDIR}/gsm"
> >> 
> >> inherit autotools pkgconfig update-rc.d
> >> -# handle update-rc.d RDEPENDS manually, we don't need it on
> >> +# handle update-rc.d RDEPENDS_${PN} manually, we don't need it on
> >> # anything but gsmd
> >> RDEPENDS_append = ""
> > 
> > This looks like some kind of bug waiting to be fixed...
> 
> Not sure what you want me to do here :)

I pushed a separate fix for gsmd andupdate-rc.d.

> >> diff --git a/meta/recipes-devtools/unfs-server/unfs-server_2.2beta47.bb b/meta/recipes-devtools/unfs-server/unfs-server_2.2beta47.bb
> >> index 89313d6..50ba339 100644
> >> --- a/meta/recipes-devtools/unfs-server/unfs-server_2.2beta47.bb
> >> +++ b/meta/recipes-devtools/unfs-server/unfs-server_2.2beta47.bb
> >> @@ -3,10 +3,10 @@ SECTION = "console/network"
> >> LICENSE = "GPLv2+"
> >> LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
> >> 
> >> -RDEPENDS = "pseudo"
> >> +RDEPENDS_${PN} = "pseudo"
> >> RDEPENDS_virtclass-native = "pseudo-native"
> >> RDEPENDS_virtclass-nativesdk = "pseudo-nativesdk"
> > 
> > Need to add ${PN} to the virtclass versions.
> 
> fixed, and that recipe seems to violate the OE versioning policy, which I didn't fix.

Hmm, it does, yes. I've fixed this.

> >> diff --git a/meta/recipes-gnome/gtk+/gtk+.inc b/meta/recipes-gnome/gtk+/gtk+.inc
> >> index c34283e..ac7795e 100644
> >> --- a/meta/recipes-gnome/gtk+/gtk+.inc
> >> +++ b/meta/recipes-gnome/gtk+/gtk+.inc
> >> @@ -35,7 +35,7 @@ FILES_${PN}-dbg += " \
> >> 	${libdir}/gtk-2.0/${LIBV}/engines/.debug/* \
> >> 	${libdir}/gtk-2.0/${LIBV}/printbackends/.debug/*"
> >> 
> >> -BASE_RRECOMMENDS = "ttf-dejavu-sans"
> >> +BASE_RRECOMMENDS_${PN} = "ttf-dejavu-sans"
> >> BASE_RRECOMMENDS_angstrom = "ttf-dejavu-sans gdk-pixbuf-loader-png gdk-pixbuf-loader-jpeg gdk-pixbuf-loader-gif gdk-pixbuf-loader-xpm"
> >> BASE_RRECOMMENDS_poky = "gdk-pixbuf-loader-png gdk-pixbuf-loader-jpeg gdk-pixbuf-loader-gif gdk-pixbuf-loader-xpm shared-mime-info"
> >> BASE_RRECOMMENDS_moblin = "gdk-pixbuf-loader-png gdk-pixbuf-loader-jpeg gdk-pixbuf-loader-gif gdk-pixbuf-loader-xpm shared-mime-info"
> > 
> > Need to add ${PN} into these. We should really consider changing the
> > default here...
> 
> fixed the PN part, not the default setting

It raises the horrible question about what the default should be I guess
(again) :/.

Cheers,

Richard