[poky] [PATCH 5/8] perl-uri: Add perl-uri

[Frans Meulenbroeks]

2010/12/8 Lu Jingdong <jingdong.lu at windriver.com>:
> Subject: [PATCH 5/8] perl-uri: Add perl-uri
>
> Add perl-uri in order to enable graphic LSB test(OLVER-Core test).
>
> Signed-off-by: Jingdong Lu <jingdong.lu at windriver.com>
> ---
>  meta/recipes-devtools/perl/perl-uri_1.56.bb |   25
> +++++++++++++++++++++++++
>  1 files changed, 25 insertions(+), 0 deletions(-)
>  create mode 100644 meta/recipes-devtools/perl/perl-uri_1.56.bb

Is there a particular naming scheme for this.
OE has liburi-perl_1.55.bb

and poky has e.g.
meta/recipes-devtools/perl/libxml-parser-perl_2.36.bb

I would have expected this to be called liburi-perl_1.56.bb
>
> diff --git a/meta/recipes-devtools/perl/perl-uri_1.56.bb
> b/meta/recipes-devtools/perl/perl-uri_1.56.bb
> new file mode 100644
> index 0000000..7dd5668
> --- /dev/null
> +++ b/meta/recipes-devtools/perl/perl-uri_1.56.bb
> @@ -0,0 +1,25 @@
> +DESCRIPTION = "This package contains the URI.pm module with friends. \
> +The module implements the URI class. URI objects can be used to access
> \
> +and manipulate the various components that make up these strings."
> +
> +SECTION = "libs"
> +LICENSE = "Artistic"

This does not seem correct:
http://www.cpan.org/authors/id/G/GA/GAAS/URI-1.56.readme says:

This library is free software; you can redistribute it and/or modify
it under the same terms as Perl itself.

THis is also what the README file says

and http://dev.perl.org/licenses/ says:

Perl5 is Copyright (C) 1993-2005, by Larry Wall and others.

It is free software; you can redistribute it and/or modify it under
the terms of either:

a) the GNU General Public License as published by the Free Software
Foundation; either external linkversion 1, or (at your option) any
later versionexternal link, or

b) the "Artistic License".

So I'd say it should be:

LICENSE = "Artistic|GPLv1+"


> +PR = "r0"
> +
> +LIC_FILES_CHKSUM =
> "file://README;beginline=26;endline=30;md5=6c33ae5c87fd1c4897714e122dd9c23d"
> +
> +DEPENDS += "perl"

This DEPENDS is already dragged in by the
inherit cpan
below. It it in meta/classes/cpan.class and says:
DEPENDS  += "${@["perl", "perl-native"][(bb.data.inherits_class('native', d))]}"
RDEPENDS  += "${@["perl", ""][(bb.data.inherits_class('native', d))]}"

> +
> +SRC_URI = "http://www.cpan.org/authors/id/G/GA/GAAS/URI-${PV}.tar.gz"Y
> +
> +S = "${WORKDIR}/URI-${PV}"
> +
> +EXTRA_CPANFLAGS = "EXPATLIBPATH=${STAGING_LIBDIR} EXPATINCPATH=
> ${STAGING_INCDIR}"
> +
> +inherit cpan
> +
> +do_compile() {
> +       export LIBC="$(find ${STAGING_DIR_TARGET}/${base_libdir}/ -name
> 'libc-*.so')"
> +       cpan_do_compile
> +}
> +
As this is a pure perl recipe it is hw independent, so it should have

PACKAGE_ARCH = "all"

also maybe one might want to add
BBCLASSEXTEND="native"

Otherwise (at least that is my understanding) recipes that depend on
this one do not build (but maybe the new style staging made the native
recipe unneeded).

Anyway (and slightly off-topic here):
we also have
meta/recipes-devtools/perl/libxml-simple-perl-native_2.18.bb
meta/recipes-devtools/perl/libxml-parser-perl-native_2.36.bb
and I guess that might well be for that reason. (and not sure why
these do not use BBCLASSEXTEND, the OE version does!)




Best regards, Frans

> --
> 1.7.0.4
> --
> Lu Jingdong
> jingdong.lu at windriver.com
> China, Wind River
>
> _______________________________________________
> poky mailing list
> poky at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>