[poky] [PATCH 1/1] curl: fix native dependency

Tian, Kevin kevin.tian at intel.com
Sun Dec 5 01:48:54 PST 2010


>From: Richard Purdie
>Sent: Monday, November 29, 2010 11:17 PM
>
>On Mon, 2010-11-29 at 14:04 +0100, Frans Meulenbroeks wrote:
>> 2010/11/29 Richard Purdie <rpurdie at linux.intel.com>:
>> > Interestingly though, if I add this to curl*.bb:
>> >
>> > FOO = "A"
>> > FOO_append = "B"
>> > FOO_append_virtclass-native = "C"
>> >
>> > and then "bitbake curl-native -e | grep FOO" (he recipe has a
>> > BBCLASSEXTEND native) what should I see?
>> >
>> > I see FOO = "AB" which is not what I thought it would do...
>> >
>>
>> Hm.
>> Please allow me the remark that, if this does not do what you as
>> expert expect it to to, that probably for mere mortals like me, this
>> is a construct that is way too complicated.
>
>Its not that its too complicated, its just that its not following what
>I've understood to be the rules that variables follow. This is probably
>a bug in the parser but I'm very careful about jumping to that
>conclusion as there could be another explanation, not least the way
>virtclass as an override is implemented. I'd be interested in Chris'
>opinion which is why I was non-committal in calling it a bug ;-).
>
>> What is the rationale that _append is not a variable? Wouldn't it be
>> more logical/orthogonal/clearer if it was (and get appended at the end
>> as most people seem to expect/assume)
>
>The point is that appends should stack and this is exactly the same as
>normal variable rules, e.g.:
>
>FOO = "A"
>FOO += "B"
>FOO += "C"
>
>and you'd expect the result to be "A B C", not "A C" which it would be
>if += was the append operator did not stack.
>

then what about:

FOO = "A"
FOO_append = "B"
FOO_append_virtclass-native = "C"

should it be "A C" or "A B C"?

I think I find the problem in current code (sent out in another mail), but the
fix would depend on the answer here. From the current code, it looks designed
for "A C".

Thanks
Kevin



More information about the poky mailing list