[meta-xilinx] [meta-xilinx-bsp][RFC] kernel-module-mali: Fix errors associated with kernel upgrade to 4.19

Mon Apr 1 13:21:20 PDT 2019

Hi JFD,

> -----Original Message-----
> From: Jean-Francois Dagenais [mailto:jeff.dagenais at gmail.com]
> Sent: Monday, April 01, 2019 12:52 PM
> To: Manjukumar Harthikote Matha <MANJUKUM at xilinx.com>
> Cc: meta-xilinx at yoctoproject.org; Madhurkiran Harikrishnan
> <MADHURKI at xilinx.com>
> Subject: Re: [meta-xilinx] [meta-xilinx-bsp][RFC] kernel-module-mali: Fix errors
> associated with kernel upgrade to 4.19
> 
> Hi Manju, guys,
> 
> I need to move up to 4.19 early for the kernel. I just tried this patchset (only after
> having made my own... I had forgotten about yours here).
> 
> I am aligned with 2018.3, using meta-xilinx-tools, but am not using meta-petalinux.
> We have our own kernel recipe which
> inherit kernel
> require recipes-kernel/linux/linux-yocto.inc
> 

Can you try with linux-xlnx master? https://github.com/Xilinx/linux-xlnx

> So using either my patches on kernel-module-mali, or yours, I get this:

We don't see the issue with above tree and the RFC patches. 

Thanks,
Manju

> 
> [  641.029489] SError Interrupt on CPU2, code 0xbf000002 -- SError
> [  641.029492] CPU: 2 PID: 5232 Comm: insmod Tainted: G        W  O      4.19.0-jfd #1
> [  641.029493] Hardware name: dublin (DT)
> [  641.029495] pstate: 80000005 (Nzcv daif -PAN -UAO)
> [  641.029497] pc : _mali_osk_mem_iowrite32+0x10/0x20 [mali]
> [  641.029498] lr : mali_pp_reset_async+0x50/0x1b0 [mali]
> [  641.029500] sp : ffffff8011ad38c0
> [  641.029501] x29: ffffff8011ad38d0 x28: ffffff80123bd000
> [  641.029504] x27: 0000000000000100 x26: ffffff80009052d0
> [  641.029508] x25: ffffff8000905280 x24: 0000000000000000
> [  641.029511] x23: 0000000000000001 x22: ffffffc036d0d600
> [  641.029514] x21: ffffff8011ad3968 x20: ffffff8000904000
> [  641.029518] x19: ffffffc035266b80 x18: 00000000fffffff0
> [  641.029521] x17: 0000000000000000 x16: 0000000000000000
> [  641.029524] x15: ffffff8008a78ad8 x14: ffffff8008ad8d10
> [  641.029527] x13: 0000000000000000 x12: 0000000000000000
> [  641.029531] x11: 0000000000000001 x10: ffffff800886ae50
> [  641.029534] x9 : ffffff8008a6e000 x8 : 0000000000000000
> [  641.029537] x7 : 0040000000000001 x6 : 0000000000000000
> [  641.029540] x5 : 0000000000000001 x4 : ffffff8049360000
> [  641.029544] x3 : 00e8000000000f07 x2 : 0000000000001fff
> [  641.029547] x1 : 0000000000001020 x0 : ffffff8009360000
> [  641.029551] Kernel panic - not syncing: Asynchronous SError Interrupt
> [  641.029553] CPU: 2 PID: 5232 Comm: insmod Tainted: G        W  O      4.19.0-jfd #1
> [  641.029555] Hardware name: dublin (DT)
> [  641.029556] Call trace:
> [  641.029557]  dump_backtrace+0x0/0x180
> [  641.029558]  show_stack+0x14/0x20
> [  641.029560]  dump_stack+0x9c/0xbc
> [  641.029561]  panic+0x130/0x278
> [  641.029562]  nmi_panic+0x6c/0x70
> [  641.029563]  arm64_serror_panic+0x74/0x80
> [  641.029565]  is_valid_bugaddr+0x0/0x8
> [  641.029566]  el1_error+0x7c/0xdc
> [  641.029568]  _mali_osk_mem_iowrite32+0x10/0x20 [mali]
> [  641.029569]  mali_pp_create+0x7c/0x350 [mali]
> [  641.029571]  mali_initialize_subsystems+0x12c/0x5f8 [mali]
> [  641.029572]  mali_probe+0xf0/0x358 [mali]
> [  641.029574]  platform_drv_probe+0x50/0xa0
> [  641.029575]  really_probe+0x1e0/0x298
> [  641.029577]  driver_probe_device+0x54/0xe8
> [  641.029578]  __driver_attach+0xe4/0xe8
> [  641.029579]  bus_for_each_dev+0x70/0xc0
> [  641.029581]  driver_attach+0x20/0x28
> [  641.029582]  bus_add_driver+0x1dc/0x208
> [  641.029583]  driver_register+0x60/0x110
> [  641.029585]  __platform_driver_register+0x44/0x50
> [  641.029586]  init_module+0x30/0x140 [mali]
> [  641.029588]  do_one_initcall+0x74/0x178
> [  641.029589]  do_init_module+0x54/0x1c0
> [  641.029591]  load_module+0x1ae4/0x2108
> [  641.029592]  __se_sys_finit_module+0xb8/0xc8
> [  641.029594]  __arm64_sys_finit_module+0x18/0x20
> [  641.029595]  el0_svc_common+0x84/0xd8
> [  641.029596]  el0_svc_handler+0x6c/0x88
> [  641.029598]  el0_svc+0x8/0xc
> [  641.029625] SMP: stopping secondary CPUs
> [  641.029626] Kernel Offset: disabled
> [  641.029628] CPU features: 0x0,20802004
> [  641.029629] Memory Limit: none
> [  641.295015] ---[ end Kernel panic - not syncing: Asynchronous SError Interrupt ]---
> 
> 
> Any clues?
> 
> 
> > On Mar 13, 2019, at 14:23, Manjukumar Matha <manjukumar.harthikote-
> matha at xilinx.com> wrote:
> >
> > From: Madhurkiran Harikrishnan <madhurkiran.harikrishnan at xilinx.com>
> >
> > These patches fixes errors caused by removal of ancient init_timer API.
> > Also, addresses the removal of hot/cold cache pages in the kernel.
> >
> > Signed-off-by: Madhurkiran Harikrishnan <madhurkiran.harikrishnan at xilinx.com>
> > Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha at xilinx.com>
> > ---
> > .../recipes-graphics/mali/kernel-module-mali.bb    |   3 +
> > ...ux-mali_memory_os_alloc-Remove-__GFP_COLD.patch |  33 +++++
> > ...memory_secure-Add-header-file-dma-direct..patch |  34 +++++
> > ...4-linux-mali_-timer-Get-rid-of-init_timer.patch | 156 +++++++++++++++++++++
> > 4 files changed, 226 insertions(+)
> > create mode 100644 meta-xilinx-bsp/recipes-graphics/mali/kernel-module-
> mali/0012-linux-mali_memory_os_alloc-Remove-__GFP_COLD.patch
> > create mode 100644 meta-xilinx-bsp/recipes-graphics/mali/kernel-module-
> mali/0013-linux-mali_memory_secure-Add-header-file-dma-direct..patch
> > create mode 100644 meta-xilinx-bsp/recipes-graphics/mali/kernel-module-
> mali/0014-linux-mali_-timer-Get-rid-of-init_timer.patch
> >