[meta-xilinx] [PATCH] machine-xilinx-default.inc: Fix misspelled "kernel-module-mali"

[Nathan Rossi]

On Sat, Jul 30, 2016 at 4:44 AM, Manjukumar Harthikote Matha
<manjukumar.harthikote-matha at xilinx.com> wrote:
>
>  Hi Mike,
>
> On 07/26/2016 03:09 AM, Mike Looijmans wrote:
>>
>> The kernel module is named "kernel-module-mali", not
>> "kernel-module-mali-modules"
>> Fix this in machine-xilinx-default.inc.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans at topic.nl>
>> ---
>>  conf/machine/include/machine-xilinx-default.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/conf/machine/include/machine-xilinx-default.inc
>> b/conf/machine/include/machine-xilinx-default.inc
>> index 02fa077..04f8558 100644
>> --- a/conf/machine/include/machine-xilinx-default.inc
>> +++ b/conf/machine/include/machine-xilinx-default.inc
>> @@ -36,5 +36,5 @@ UBOOT_ELF ?= "u-boot"
>>  UBOOT_ELF_aarch64 ?= "u-boot.elf"
>>
>>  # kernel modules for ZynqMP
>> -MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS_append_zynqmp = "
>> kernel-module-mali-modules"
>> +MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS_append_zynqmp = " kernel-module-mali"
>
> I was following the guidelines from Yocto documents
> http://www.yoctoproject.org/docs/1.6.1/kernel-dev/kernel-dev.html#incorporating-out-of-tree-modules
> My understanding is that when we inherit module.bbclass, it will package
> with "kernel-module-" prefix, hence we just use that for
> MACHINE_ESSENTIAL_EXTRA packages.

That document states that the "kernel-module-*" matches the name of
the actual module, not the PN for the recipe. Written in that document
as "Where the value is derived by appending the module filename
without the .ko extension to the string "kernel-module-"".

This matches the actual output that is built, with the kernel-module
being located in a package with the name "kernel-module-mali".

packages-split/kernel-module-mali/lib/modules/4.4.0-xilinx/extra/mali.ko

So I believe Mike's patch is correct in fixing up the M*_E*_E*_R*
append. Manju could you confirm this is as expected? and the .ko is
not supposed to be instead named 'mali-modules' (which would be an odd
name for a singular module ;)).

Regards,
Nathan

>
> Thanks
> Manju
>
> --
> _______________________________________________
> meta-xilinx mailing list
> meta-xilinx at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-xilinx