[meta-virtualization] [PATCH] python-glanceclient: upgrade 2.8.0 -> 2.16.0

Mark Asselstine mark.asselstine at windriver.com
Thu Sep 5 05:56:21 PDT 2019


On Tuesday, September 3, 2019 7:52:55 P.M. EDT Zheng, Ruoqin wrote:
> To Mark
> 
> 
> > What's with the extra churn here? Was the moving around of lines
> > deliberate, if
 so it needs to be covered in the long log. If not you
> > should avoid this as it is similar to mixing real changes and non-real
> > changes, it only serves to make the review more difficult.
> > 
> > MarkA
> 
> 
> Sorry,I will be careful next time.

np. Thanks for keeping this in mind in the future.

MarkA

> 
> --------------------------------------------------
> Zheng Ruoqin
> Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
> ADDR.: No.6 Wenzhu Road, Software Avenue,
>        Nanjing, 210012, China
> MAIL : zhengrq.fnst at cn.fujistu.com
> 
> 
> 
> > -----Original Message-----
> > From: Mark Asselstine [mailto:mark.asselstine at windriver.com]
> > Sent: Wednesday, September 04, 2019 4:46 AM
> > To: Zheng, Ruoqin/郑 若钦 <zhengrq.fnst at cn.fujitsu.com>
> > Cc: meta-virtualization <meta-virtualization at yoctoproject.org>
> > Subject: Re: [meta-virtualization] [PATCH] python-glanceclient: upgrade
> > 2.8.0 ->
 2.16.0
> > 
> > On Mon, Sep 2, 2019 at 7:53 AM Zheng Ruoqin <zhengrq.fnst at cn.fujitsu.com>
> > wrote:
> > 
> > >
> > >
> > > Signed-off-by: Zheng Ruoqin <zhengrq.fnst at cn.fujitsu.com>
> > > ---
> > > 
> > >  .../python/python-glanceclient_git.bb          | 18 ++++++++----------
> > >  1 file changed, 8 insertions(+), 10 deletions(-)
> > >
> > >
> > >
> > > diff --git
> > > a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> > > b/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> > > index 00ea2ab..e828cba 100644
> > > ---
> > > a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> > > +++ b/meta-openstack/recipes-devtools/python/python-glanceclient_git.b
> > > +++ b
> > > @@ -3,22 +3,20 @@ HOMEPAGE = "https://github.com/openstack/python-> > 
> > glanceclient"
> > 
> > >  SECTION = "devel/python"
> > >  LICENSE = "Apache-2.0"
> > >  LIC_FILES_CHKSUM =
> > 
> > "file://LICENSE;md5=34400b68072d710fecd0a2940a0d1658"
> > 
> > > +SRC_URI = "git://github.com/openstack/python-glanceclient.git \
> > > +           file://glance-api-check.sh \
> > > +        "
> > > +
> > > +PV = "2.16.0+git${SRCPV}"
> > > +SRCREV = "44a4dbd6ce2642daeaca9f45ac99e2d1b39e805a"
> > > +S = "${WORKDIR}/git"
> > > +
> > > 
> > >  DEPENDS += " \
> > >  
> > >          gmp \
> > >          python-pip \
> > >          python-pbr \
> > >          "
> > >
> > >
> > >
> > > -SRCREV = "13b25ff1fed908cfe7b4e719a97efd7121e3be96"
> > > -PV = "2.8.0+git${SRCPV}"
> > > -
> > > -SRC_URI = "\
> > > -       git://github.com/openstack/${BPN}.git;branch=stable/pike \
> > > -       file://glance-api-check.sh \
> > > -       "
> > > -
> > > -S = "${WORKDIR}/git"
> > 
> > 
> > What's with the extra churn here? Was the moving around of lines
> > deliberate, if
 so it needs to be covered in the long log. If not you
> > should avoid this as it is similar to mixing real changes and non-real
> > changes, it only serves to make the review more difficult.
> > 
> > MarkA
> > 
> > 
> > > -
> > > 
> > >  inherit setuptools monitor rmargparse
> > >
> > >
> > >
> > >  FILES_${PN} += "${datadir}/${SRCNAME}"
> > > 
> > > --
> > > 2.17.1
> > >
> > >
> > >
> > >
> > >
> > > --
> > > _______________________________________________
> > > meta-virtualization mailing list
> > > meta-virtualization at yoctoproject.org
> > > https://lists.yoctoproject.org/listinfo/meta-virtualization
> > 
> > 
> 
> 






More information about the meta-virtualization mailing list