[meta-virtualization] [PATCH] recipes-extended/xen/xen.inc: Add RDEPENDS_${PN}-pygrub

[Norbert Kaminski]

On 18.11.2019 06:39, Christopher Clark wrote:
> On Sun, Nov 17, 2019 at 7:37 PM Bruce Ashfield 
> <bruce.ashfield at gmail.com> wrote:
>> On Thu, Nov 14, 2019 at 9:24 AM Norbert Kaminski
>> <norbert.kaminski at 3mdeb.com> wrote:
>>> From ea86f97c347f6637d85a6fdbf36943d43adfa18e Mon Sep 17 00:00:00 2001
>>> From: Norbert Kaminski <norbert.kaminski at 3mdeb.com>
>>> Date: Tue, 12 Nov 2019 11:25:29 +0100
>>> Subject: [PATCH] recipes-extended/xen/xen.inc: Add RDEPENDS_${PN}-pygrub
>> Maybe: "xen: fix pygrub runtime by adding xen-python to xen-pygrub
>> RDEPENDS" as the shortlog ?
>>
>>> The patch fixes a problem with importing the package xen.lowlevel.xc.
>>> RDEPENDS add the xen-python tool, which contains the package.
>> Can we expand on this message a bit ?
>>
>> I assume that something from xen.lowlevel.xc is pulling in pygrub, and
>> that in turn requires xen-python? What is the actual on-target or boot
>> issue this then triggers ?
>>
>> I'm not currently able to do Xen runtime tests (and hence can't see
>> this for myself), so I'm trying to understand the issue just from the
>> commit message (and failing at the moment).
> One issue that Norbert's patch fixes is: when xen-pygrub is added to
> an image, it doesn't pull in the xen-python package that it needs
> which contains the support
> library xen.lowlevel.xc .
That issue happened to me, while I was building an ipfire vm guest.
The image is splited into three parts and therefore needs a pygrub to 
work as a vm.
Pygrub imports the xen.lowlevel.xc, which is included in the xen-python 
package.
Therefore I'm adding a xen-python in the patch.

Norbert

> I've build-tested a similar patch in a related environment and I think
> the patch should also have this too:
>
> +RDEPENDS_${PN}-python = " \
> + python \
> + "
>
> Christopher
>
>
>
>> Cheers,
>>
>> Bruce
>>
>>> Signed-off-by: Norbert Kaminski <norbert.kaminski at 3mdeb.com>
>>> ---
>>> recipes-extended/xen/xen.inc | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
>>> index 628e52b..ba00d2a 100644
>>> --- a/recipes-extended/xen/xen.inc
>>> +++ b/recipes-extended/xen/xen.inc
>>> @@ -151,6 +151,8 @@ RDEPENDS_${PN}-xentrace = "python"
>>>
>>> RDEPENDS_${PN}-xen-watchdog = "bash"
>>>
>>> +RDEPENDS_${PN}-pygrub = "${PN}-python"
>>> +
>>> PACKAGES = "\
>>> ${PN}-base \
>>> ${PN}-blktap \
>>> --
>>> 2.17.1
>>>
>>> --
>>> _______________________________________________
>>> meta-virtualization mailing list
>>> meta-virtualization at yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>>
>>
>> --
>> - Thou shalt not follow the NULL pointer, for chaos and madness await
>> thee at its end
>> - "Use the force Harry" - Gandalf, Star Trek II
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization at yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization