[meta-virtualization] recipes-extended/images/xen-image-minimal.bb: change, hardcoded vmlinuz to the KERNEL_IMAGETYPE variable

[Bruce Ashfield]

On Thu, Nov 14, 2019 at 9:22 AM Norbert Kaminski
<norbert.kaminski at 3mdeb.com> wrote:
>
>
> On 31.10.2019 23:09, Bruce Ashfield wrote:
> > On Thu, Oct 31, 2019 at 2:23 PM Norbert Kaminski
> > <norbert.kaminski at 3mdeb.com> wrote:
> >> Why is vmlinuz hard-coded in the syslinux.cfg? Could it be replaced by
> >> the KERNEL_IMAGETYPE?
> >>
> > I'm guessing it just hasn't been something that others have wanted to configure.
> >
> > The patch looks ok to me. I assume those that are currently relying on
> > /vmlinuz will have that already as their kernel build type (since it
> > is being built).
> >
> > I'll wait a few days to see if anyone objects.
>
> So far, there have been no objections, thus I think it could be merged.

I've sent a few specific requests out for comment, I'm still waiting
to hear back.

Bruce

>
> Norbert
>
> > Bruce
> >
> >
> >>   From 450becb15192a3541b7a3d55ace75a1929d15add Mon Sep 17 00:00:00 2001
> >> From: Asiderr <norbert.kaminski at 3mdeb.com>
> >> Date: Thu, 31 Oct 2019 17:50:53 +0100
> >> Subject: [PATCH] recipes-extended/images/xen-image-minimal.bb: change
> >> hardcoded vmlinuz to the variable
> >>
> >> Signed-off-by: Norbert Kaminski <norbert.kaminski at 3mdeb.com>
> >> ---
> >>    recipes-extended/images/xen-image-minimal.bb | 2 +-
> >>    1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/recipes-extended/images/xen-image-minimal.bb
> >> b/recipes-extended/images/xen-image-minimal.bb
> >> index c39d378..740ef1f 100644
> >> --- a/recipes-extended/images/xen-image-minimal.bb
> >> +++ b/recipes-extended/images/xen-image-minimal.bb
> >> @@ -61,6 +61,6 @@ build_syslinux_cfg () {
> >>        echo "PROMPT 1" >> ${SYSLINUX_CFG}
> >>        echo "LABEL boot" >> ${SYSLINUX_CFG}
> >>        echo "  KERNEL mboot.c32" >> ${SYSLINUX_CFG}
> >> -    echo "  APPEND /xen.gz ${SYSLINUX_XEN_ARGS} --- /vmlinuz
> >> ${SYSLINUX_KERNEL_ARGS} --- /initrd" >> ${SYSLINUX_CFG}
> >> +    echo "  APPEND /xen.gz ${SYSLINUX_XEN_ARGS} ---
> >> /${KERNEL_IMAGETYPE} ${SYSLINUX_KERNEL_ARGS} --- /initrd" >> ${SYSLINUX_CFG}
> >>    }
> >>
> >> --
> >> 2.17.1
> >>
> >> --
> >> _______________________________________________
> >> meta-virtualization mailing list
> >> meta-virtualization at yoctoproject.org
> >> https://lists.yoctoproject.org/listinfo/meta-virtualization
> >
> >



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II