[meta-virtualization] [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict

Bruce Ashfield bruce.ashfield at gmail.com
Sat Mar 16 17:22:57 PDT 2019


This is now merged

Bruce

On Thu, Mar 14, 2019 at 9:33 PM Bruce Ashfield <bruce.ashfield at gmail.com> wrote:
>
> On Thu, Mar 14, 2019 at 10:18 AM Mark Hatle <mark.hatle at windriver.com> wrote:
> >
> > On 3/13/19 9:59 PM, Bruce Ashfield wrote:
> > > I'm waiting for Mark to reply to your explanation. He had the open
> > > question, I'm waiting for him to ack it.
> >
> > Sorry, I had nothing to add.. I was satisfied with the answer.
> >
> > Ack.
>
> ok. Sounds good. I'm traveling tomorrow, so I'll take care of
> outstanding merges over the weekend.
>
> Bruce
>
> >
> > --Mark
> >
> > > Bruce
> > >
> > > On Wed, Mar 13, 2019 at 8:12 PM ddu <dengke.du at windriver.com> wrote:
> > >>
> > >> Ping.
> > >>
> > >> 在 2019/3/7 上午10:58, Dengke Du 写道:
> > >>> The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
> > >>> so we should append it, not override.
> > >>>
> > >>> Signed-off-by: Dengke Du <dengke.du at windriver.com>
> > >>> ---
> > >>>   meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
> > >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > >>> index b55f9a9..0b0f011 100644
> > >>> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > >>> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > >>> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
> > >>>
> > >>>   inherit useradd
> > >>>   USERADD_PACKAGES = "${PN}"
> > >>> -GROUPADD_PARAM_${PN} = "--system libvirt"
> > >>> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
> > >>>
> > >>>   do_install_append() {
> > >>>       sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
> > >> --
> > >> _______________________________________________
> > >> meta-virtualization mailing list
> > >> meta-virtualization at yoctoproject.org
> > >> https://lists.yoctoproject.org/listinfo/meta-virtualization
> > >
> > >
> > >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


More information about the meta-virtualization mailing list