[meta-virtualization] [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict

Mark Hatle mark.hatle at windriver.com
Thu Mar 7 06:00:57 PST 2019


On 3/6/19 8:58 PM, Dengke Du wrote:
> The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
> so we should append it, not override.
> 
> Signed-off-by: Dengke Du <dengke.du at windriver.com>
> ---
>  meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> index b55f9a9..0b0f011 100644
> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
>  
>  inherit useradd
>  USERADD_PACKAGES = "${PN}"
> -GROUPADD_PARAM_${PN} = "--system libvirt"
> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"

The __append should be fine then, but why the ';'?  That part looks wrong, since
typically the PARAM is the parameters passed directly to the groupadd program.
I don't believe ';' is a valid parameter.

--Mark

>  do_install_append() {
>  	sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
> 



More information about the meta-virtualization mailing list