[meta-virtualization] [PATCH] docker: readd docker-init to RRECOMMENDS

[Bruce Ashfield]

On Mon, Jun 24, 2019 at 8:47 AM Stefan Agner <stefan at agner.ch> wrote:
>
> From: Stefan Agner <stefan.agner at toradex.com>
>
> If docker run --init is used docker expects docker-init to be
> present. However, it has been removed by commit d19fda374317
> ("docker: consolidate common depends/options"). Readd docker-init
> to RRECOMMENDS to make sure its typically deployed.
>

The more I think about it, this should either just be a RDEPENDS all the time ..
or a PACKAGECONFIG RDEPENDS.

Since it is functionality that docker may look for, the RRECOMMENDS seems
to weak.

Making it a packageconfig gives us the most flexibility, since it hasn't been
installed since I did the re-work, and no one else has noticed :D So if we make
it a packageconfig, it is trivial to add for anyone that wants it, and we can
consider making it a default packageconfig in the fall release.

Bruce

> Signed-off-by: Stefan Agner <stefan.agner at toradex.com>
> ---
>  recipes-containers/docker/docker.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-containers/docker/docker.inc b/recipes-containers/docker/docker.inc
> index 168d296..e4ff353 100644
> --- a/recipes-containers/docker/docker.inc
> +++ b/recipes-containers/docker/docker.inc
> @@ -29,7 +29,7 @@ RDEPENDS_${PN} = "util-linux util-linux-unshare iptables \
>                   "
>  RDEPENDS_${PN} += "virtual/containerd virtual/runc"
>
> -RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat"
> +RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat docker-init"
>
>  inherit pkgconfig
>  PACKAGECONFIG ??= ""
> --
> 2.13.6
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II