[meta-virtualization] [PATCH 3/4] cni: upgrade git version to latest master

[Bruce Ashfield]

On Tue, Aug 13, 2019 at 8:30 AM Bruce Ashfield <bruce.ashfield at gmail.com>
wrote:

>
>
> On Tue, Aug 13, 2019 at 3:51 AM Chen Qi <Qi.Chen at windriver.com> wrote:
>
>> Upgrade the git version to latest master to make the recipe
>> truly serve its purpose.
>>
>
> That's  not a good reason to do the uprev, this is a git recipe because it
> makes sense for it to be git .. not because it is tracking the tip of
> master all the time.
>
> What *actual* functionality are we getting from this ? How was it tested ?
>

Ignore this comment, since I was reviewing the patches in order, and I saw
the locked version split after writing this comment.

But the comment I made to the other patches still stands. We don't want
extra/double maintenance, so just uprev the recipe to where it works with
k8s (preferably the latest version at the time, since that is what I always
do), and we'll support that.

Since it is a _git recipe, it is trivial for people to bump it for local
testing, there's no need for the two variants.

Bruce



>
> Bruce
>
>
>
>>
>> This upgrades both cni and plugins repos.
>>
>> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
>> ---
>>  recipes-networking/cni/cni_git.bb | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/recipes-networking/cni/cni_git.bb b/recipes-networking/cni/
>> cni_git.bb
>> index 06b37a4..60c39f1 100644
>> --- a/recipes-networking/cni/cni_git.bb
>> +++ b/recipes-networking/cni/cni_git.bb
>> @@ -1,10 +1,10 @@
>>  # This cni version is supposed to track latest upstream.
>>  require cni.inc
>>
>> -SRCREV_cni = "dc71cd2ba60c452c56a0a259f2a23d2afe42b688"
>> -SRCREV_plugins = "0eddc554c0747200b7b112ce5322dcfa525298cf"
>> +SRCREV_cni = "8c6c47d1c7fcf51c8d0c939d2af06dd108f876da"
>> +SRCREV_plugins = "2d6d4b260a98973a206fde18bdde4f2511c72c60"
>>  SRC_URI = "\
>>         git://github.com/containernetworking/cni.git;nobranch=1;name=cni
>> \
>>          git://
>> github.com/containernetworking/plugins.git;nobranch=1;destsuffix=plugins;name=plugins
>> \
>>         "
>> -PV = "0.7.0+git${SRCREV_cni}"
>> +PV = "0.7.1+git${SRCREV_cni}"
>> --
>> 2.17.1
>>
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization at yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-virtualization/attachments/20190813/9bfd55d1/attachment.html>