[meta-virtualization] [PATCH 2/4] runc: remove static to enable building systemd support

[Bruce Ashfield]

On Mon, Aug 5, 2019 at 8:52 AM ChenQi <Qi.Chen at windriver.com> wrote:

> On 08/05/2019 07:28 PM, Bruce Ashfield wrote:
>
>
>
> On Mon., Aug. 5, 2019, 3:02 a.m. Chen Qi, <Qi.Chen at windriver.com> wrote:
>
>> Remove the 'static' from do_compile to enable systemd support.
>> This avoid runtime error is docker's cgroup driver is set to systemd
>> on systemd based images.
>>
>> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
>> ---
>>  recipes-containers/runc/runc.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-containers/runc/runc.inc
>> b/recipes-containers/runc/runc.inc
>> index 46fd09d..1f2f944 100644
>> --- a/recipes-containers/runc/runc.inc
>> +++ b/recipes-containers/runc/runc.inc
>> @@ -54,7 +54,7 @@ do_compile() {
>>         export CFLAGS=""
>>         export LDFLAGS=""
>>
>> -       oe_runmake static
>> +       oe_runmake
>>
>
>
> This needs to be optional, via a packageconfig that can be overidden and
> that can trigger a default of the init manager is systemd. (I actually want
> static and systemd in my configs )
>
> Bruce
>
>
> So we introduce a PACKAGECONFIG, whose effect is using static when enabled
> and dropping static when disabled. By default, it's disabled if systemd is
> in use.
>


Yes. That's what I meant, but on further thought, I'd prefer to not change
the default build config even with systemd enabled at the moment.

So we can introduce a packageconfig, make static the default and then allow
bbappends to change it to what they want. Once it has been in the layer for
a bit, we can change the default.

Bruce



>
> Right?
>
> Regards,
> Chen Qi
>
>  }
>>
>>  do_install() {
>> --
>> 2.17.1
>>
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization at yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>>
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-virtualization/attachments/20190805/e9bc9841/attachment.html>