[meta-virtualization] [PATCH 2/4] runc: remove static to enable building systemd support

[Mark Hatle]

On 8/5/19 7:05 AM, ChenQi wrote:
> On 08/05/2019 07:28 PM, Bruce Ashfield wrote:
>>
>>
>> On Mon., Aug. 5, 2019, 3:02 a.m. Chen Qi, <Qi.Chen at windriver.com
>> <mailto:Qi.Chen at windriver.com>> wrote:
>>
>>     Remove the 'static' from do_compile to enable systemd support.
>>     This avoid runtime error is docker's cgroup driver is set to systemd
>>     on systemd based images.
>>
>>     Signed-off-by: Chen Qi <Qi.Chen at windriver.com <mailto:Qi.Chen at windriver.com>>
>>     ---
>>      recipes-containers/runc/runc.inc | 2 +-
>>      1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>     diff --git a/recipes-containers/runc/runc.inc
>>     b/recipes-containers/runc/runc.inc
>>     index 46fd09d..1f2f944 100644
>>     --- a/recipes-containers/runc/runc.inc
>>     +++ b/recipes-containers/runc/runc.inc
>>     @@ -54,7 +54,7 @@ do_compile() {
>>             export CFLAGS=""
>>             export LDFLAGS=""
>>
>>     -       oe_runmake static
>>     +       oe_runmake
>>

runc is one of those things that may need to be static in some configurations.
Since it has security impact, updating runc (and the libc) should be done in
paralell and this can cause problems otherwise.

Now, that doesn't mean it HAS to be static, but it should be a configuration and
may be wise to have as the default to be static.

>>
>> This needs to be optional, via a packageconfig that can be overidden and that
>> can trigger a default of the init manager is systemd. (I actually want static
>> and systemd in my configs )
>>
>> Bruce
>>
> 
> So we introduce a PACKAGECONFIG, whose effect is using static when enabled and
> dropping static when disabled. By default, it's disabled if systemd is in use.

So PACKAGECONFIG is the right answer here.  I'm not sure what the right default
for the recipe is.... but in the end the users configuration and distro can and
should be able to select what they want.

--Mark

> Right?
> 
> Regards,
> Chen Qi
> 
>>      }
>>
>>      do_install() {
>>     -- 
>>     2.17.1
>>
>>     -- 
>>     _______________________________________________
>>     meta-virtualization mailing list
>>     meta-virtualization at yoctoproject.org
>>     <mailto:meta-virtualization at yoctoproject.org>
>>     https://lists.yoctoproject.org/listinfo/meta-virtualization
>>
> 
>