[meta-virtualization] [PATCH 6/6] layer.conf: depend on meta-webserver as nagios-core depends on apache2

[ChenQi]

On 09/06/2018 04:43 AM, Bruce Ashfield wrote:
> But nagios won't always be installed/used, so this is not a hard dependency of
> meta-virtualization.

If you don't think we should depend on webserver layer, ignore this patch.
I agree that it's not a hard dependency.

> So while I don't mind this going into the README as a depends, I don't think it
> belongs in the layer.conf.

Should we consider using LAYERRECOMMENDS? I'll send out V2 with this change.

> Also, can we have a README for how nagios works, and should be sanity tested ?
> As it stands right now, I have no way to know how to build and test it.

The runtime tests I did are:
1. systemctl status nagios-core
2. systemctl status nagios-nrpe
3. systemctl status nagios-nsca

These services started correctly without any error.

I agree that maybe more detailed usage examples and tests are better.
However, currently I don't have time for this.
People interested in nagios could find sufficient documents on nagios's 
official website.
Also, we don't have substantial patches that could possibly affect the 
service logic of nagios.

Best Regards,
Chen Qi


> I'll wait for a v2 with those changes.
>
> Bruce
>
> On Mon, Sep 3, 2018 at 10:47 PM, Chen Qi <Qi.Chen at windriver.com> wrote:
>> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
>> ---
>>   conf/layer.conf | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/conf/layer.conf b/conf/layer.conf
>> index eaef1b7..ad2c96e 100644
>> --- a/conf/layer.conf
>> +++ b/conf/layer.conf
>> @@ -21,6 +21,7 @@ LAYERDEPENDS_virtualization-layer = " \
>>       networking-layer \
>>       filesystems-layer \
>>       meta-python \
>> +    webserver \
>>   "
>>
>>   # Override security flags
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization at yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>
>