[meta-virtualization] ipxe: do_compile failing on rocko

[Ken Bassford]

Looks like it failed (not surprising considering our build server is semi-isolated).
(Below is what I tried to send from /var/mail/kbassford)

Return-path: <kbassford at build-server1>
Received: from kbassford by build-server1 with local (Exim 4.84_2)
	(envelope-from <kbassford at build-server1>)
	id 1gFPp3-0005Io-JW
	for meta-virtualization at yoctoproject.org; Wed, 24 Oct 2018 16:32:09 -0400
From: Ken <kbassford at apertussolutions.com>
To: meta-virtualization at yoctoproject.org
Subject: 
Date: Wed, 24 Oct 2018 16:32:05 -0400
Message-Id: <20181024203206.20337-1-kbassford at apertussolutions.com>
X-Mailer: git-send-email 2.11.0

diff --git a/recipes-extended/ipxe/ipxe_git.bb b/recipes-extended/ipxe/ipxe_git.bb
index c0c8a7b..e0b386f 100644
--- a/recipes-extended/ipxe/ipxe_git.bb
+++ b/recipes-extended/ipxe/ipxe_git.bb
@@ -12,7 +12,7 @@ SRC_URI = "git://git.ipxe.org/ipxe.git;protocol=https"
 
 FILES_${PN} = "/usr/share/firmware/*.rom"
 
-EXTRA_OEMAKE = "NO_WERROR=1"
+EXTRA_OEMAKE = "NO_WERROR=1 ISOLINUX_BIN="${STAGING_DIR_TARGET}/usr/share/syslinux/isolinux.bin" CROSS_COMPILE="${TARGET_PREFIX}""
 #PARALLEL_MAKE=""
 
 S = "${WORKDIR}/git/src"

# Received in log "...poky/build/tmp/work/core2-64-poky-linux/ipxe/gitrAUTOINC+8c43891db4-r0/temp/log.do_compile" 
# 
# Assembler messages: 
# "/tmp/ccEectOc.s:28: Error: missing or invalid displacement expression `private_key_len at GOTOFF'  
#  /tmp/ccEectOc.s:28: Error: missing or invalid displacement expression `private_key_len at GOTOFF'" 
#
# This change reflects the current master branch for this file.
#

2.11.0

Cheers,
Ken


 ---- On Wed, 24 Oct 2018 15:49:01 -0400 Randy MacLeod <randy.macleod at windriver.com> wrote ---- 
 > On 10/24/18 3:35 PM, Ken Bassford wrote: 
 > > Hi Randy, 
 > >  
 > > Took me a while as I had edited outside of git. 
 > >  
 > > Got all the way down to the "git send-email" command. 
 > >  
 > > "git: 'send-email' is not a git command. See 'git --help'" 
 > > Sorry, I thought I could save you the trouble. 
 >  
 > I will teach you to fish! :) 
 >  
 > You need the git-email package on Ubuntu at least. 
 >  
 > I kind of knew that but I confirmed using: 
 > $ git send-email --dry-run ... 
 > with strace: 
 > $ strace -f -o /tmp/gse.log git send-email --dry-run ... 
 >  
 > $ grep exec /tmp/gse.log | grep send-email | me-filtering-details 
 > ... 
 > .../usr/lib/git-core/git-send-email... 
 > ... 
 >  
 > so checking that package: 
 > $ dpkg -S /usr/lib/git-core/git-send-email 
 > git-email: /usr/lib/git-core/git-send-email 
 >  
 >  
 > Can you install that package and try again? 
 > Don't forget about the git setup steps in: 
 >    https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded 
 >  
 > If you get stuck, let me know. 
 >  
 > ../Randy 
 >  
 >  
 > >  
 > > Sincerely, 
 > > Ken Bassford 
 > > Apertus Solutions 
 > >  
 > >   ---- On Wed, 24 Oct 2018 14:54:14 -0400 Randy MacLeod <randy.macleod at windriver.com> wrote ---- 
 > >   > On 10/24/18 10:28 AM, Ken Bassford wrote: 
 > >   > > Hello again, 
 > >   > > 
 > >   > > Found another bug ... 
 > >   > > 
 > >   > > Received in log "...poky/build/tmp/work/core2-64-poky-linux/ipxe/gitrAUTOINC+8c43891db4-r0/temp/log.do_compile" 
 > >   > > 
 > >   > > Assembler messages: 
 > >   > > "/tmp/ccEectOc.s:28: Error: missing or invalid displacement expression `private_key_len at GOTOFF' 
 > >   > > 
 > >   > > /tmp/ccEectOc.s:28: Error: missing or invalid displacement expression `private_key_len at GOTOFF'" 
 > >   > > 
 > >   > > Change to ipxe_git.bb that enabled compile to work. 
 > >   > 
 > >   > You've shown the error, that's good. It should go in the body / long log 
 > >   > of you git commit message. 
 > >   > 
 > >   > You also need to explain why this change makes sense. 
 > >   > In this case you can just point to the commit on master by saying: 
 > >   > 
 > >   > Set the isolinux bin variable used in Makefile as was done on 
 > >   > master in commit: 
 > >   >     fd68542 ipxe: recipe cleanup and uprev to current 
 > >   > 
 > >   > > 
 > >   > > - #EXTRA_OEMAKE = "NO_WERROR=1" 
 > >   > > + EXTRA_OEMAKE = "NO_WERROR=1 ISOLINUX_BIN="${STAGING_DIR_TARGET}/usr/share/syslinux/isolinux.bin" CROSS_COMPILE="${TARGET_PREFIX}"" 
 > >   > 
 > >   > Ken, 
 > >   > 
 > >   > Would you be able to re-submit as a patch as I did and 
 > >   > explained for the SRC_URI change for seabios for morty? 
 > >   > 
 > >   > Thanks, 
 > >   > ../Randy 
 > >   > > 
 > >   > > [reply] [-] Comment 1 Randy MacLeod 2018-10-24 14:19:29 UTC 
 > >   > > Hi Ken and other meta-virt users who may read this defect, 
 > >   > > 
 > >   > > as you realize, ipxe is from: 
 > >   > > http://git.yoctoproject.org/cgit/cgit.cgi/meta-virtualization/tree/recipes-extended/ipxe/ipxe_git.bb?h=master 
 > >   > > 
 > >   > > meta-virtualization doesn't use the YP bugzilla. 
 > >   > > As it says in the meta-virt README: 
 > >   > > 
 > >   > > Maintenance 
 > >   > > ----------- 
 > >   > > 
 > >   > > Send pull requests, patches, comments or questions to meta-virtualization at yoctoproject.org 
 > >   > > 
 > >   > > Maintainer: Bruce Ashfield <bruce.ashfield at gmail.com> 
 > >   > > 
 > >   > > When sending single patches, please using something like: 
 > >   > > $ git send-email -1 -M --to meta-virtualization at yoctoproject.org --subject-prefix='meta-virtualization][PATCH' 
 > >   > > 
 > >   > > --------------------------------------------- 
 > >   > > 
 > >   > > meta-virt is welcome to use bugzilla but they have decide to just use the email list. 
 > >   > > 
 > >   > > Sincerely, 
 > >   > > Ken Bassford 
 > >   > > Apertus Solutions 
 > >   > > 
 > >   > > 
 > >   > 
 > >   > 
 > >   > -- 
 > >   > # Randy MacLeod 
 > >   > # Wind River Linux 
 > >   > 
 > >  
 >  
 >  
 > --  
 > # Randy MacLeod 
 > # Wind River Linux 
 >