[meta-virtualization] [PATCH] docker: fix package qa warning

[M. Asselstine]

On Sun, Sep 30, 2018 at 9:23 PM, Bruce Ashfield
<bruce.ashfield at gmail.com> wrote:
> On Sat, Sep 29, 2018 at 11:18 PM <changqing.li at windriver.com> wrote:
>>
>> From: Changqing Li <changqing.li at windriver.com>
>>
>> fix below warning:
>> do_package_qa: QA Issue: ELF binary 'xxx/usr/bin/docker'
>> has relocations in .text [textrel]
>>
>> Signed-off-by: Changqing Li <changqing.li at windriver.com>
>> ---
>>  recipes-containers/docker/docker_git.bb            |  1 +
>>  .../files/0001-fix-do_package_qa-error.patch       | 31 ++++++++++++++++++++++
>>  2 files changed, 32 insertions(+)
>>  create mode 100644 recipes-containers/docker/files/0001-fix-do_package_qa-error.patch
>>
>> diff --git a/recipes-containers/docker/docker_git.bb b/recipes-containers/docker/docker_git.bb
>> index 73e0120..1a8d1a6 100644
>> --- a/recipes-containers/docker/docker_git.bb
>> +++ b/recipes-containers/docker/docker_git.bb
>> @@ -28,6 +28,7 @@ SRC_URI = "\
>>         file://docker.init \
>>         file://hi.Dockerfile \
>>          file://0001-libnetwork-use-GO-instead-of-go.patch \
>> +        file://0001-fix-do_package_qa-error.patch \
>>         "
>>
>>  # Apache-2.0 for docker
>> diff --git a/recipes-containers/docker/files/0001-fix-do_package_qa-error.patch b/recipes-containers/docker/files/0001-fix-do_package_qa-error.patch
>> new file mode 100644
>> index 0000000..79e71a5
>> --- /dev/null
>> +++ b/recipes-containers/docker/files/0001-fix-do_package_qa-error.patch
>> @@ -0,0 +1,31 @@
>> +From 56c865e2a7269d63f0780b4cd1ed6fdb18e3ff1b Mon Sep 17 00:00:00 2001
>> +From: Changqing Li <changqing.li at windriver.com>
>> +Date: Wed, 26 Sep 2018 17:41:59 +0800
>> +Subject: [PATCH] fix do_package_qa error
>> +
>> +fix below error:
>> +do_package_qa: QA Issue: ELF binary 'xxx/usr/bin/docker'
>> +has relocations in .text [textrel]
>> +
>> +Upstream-Status: Inappropriate [oe-specific]
>> +
>> +Signed-off-by: Changqing Li <changqing.li at windriver.com>
>> +---
>> + cli/scripts/build/dynbinary | 2 +-
>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>> +
>> +diff --git a/cli/scripts/build/dynbinary b/cli/scripts/build/dynbinary
>> +index 3c32ed3..938e086 100755
>> +--- a/cli/scripts/build/dynbinary
>> ++++ b/cli/scripts/build/dynbinary
>> +@@ -9,6 +9,6 @@ source ./scripts/build/.variables
>> +
>> + echo "Building dynamically linked $TARGET"
>> + export CGO_ENABLED=1
>> +-go build -o "${TARGET}" -tags pkcs11 --ldflags "${LDFLAGS}" "${SOURCE}"
>> ++go build -o "${TARGET}" -tags pkcs11 --ldflags "${LDFLAGS}" -buildmode=pie "${SOURCE}"
>
> As I mentioned in my other replies, I've never seen these warnings
> myself. So I need to understand the configuration better.
>
> Since I've never seen this before, my first reaction is that any
> change of the flags to include buildmode=pie needs to be conditional
> on some other distro feature that is enabled in your configuration.

Most likely the security flags at play. Could also be that you don't
have the check enabled. At any rate I agree the details need to be
captured in the commit log.

MarkA

>
> Bruce
>
>> +
>> + ln -sf "$(basename "${TARGET}")" build/docker
>> +--
>> +2.7.4
>> +
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization at yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization