[meta-virtualization] [PATCH] containerd: remove redundant systemd detection
Bruce Ashfield
bruce.ashfield at gmail.com
Wed Mar 14 05:39:39 PDT 2018
On Wed, Mar 14, 2018 at 4:39 AM, Pascal Bach <pascal.bach at siemens.com> wrote:
> The variables only take effect if systemd is enabled so the check can be removed.
>
Same comment.
This layer, and many others, have always had this check since that's
how the systemd
classes worked before.
Can you log the oe-core commit that changes the behaviour in the long
log of the two
cleanup patches ?
Bruce
> Signed-off-by: Pascal Bach <pascal.bach at siemens.com>
> ---
> recipes-containers/containerd/containerd.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-containers/containerd/containerd.inc b/recipes-containers/containerd/containerd.inc
> index f91e018..801ace1 100644
> --- a/recipes-containers/containerd/containerd.inc
> +++ b/recipes-containers/containerd/containerd.inc
> @@ -53,8 +53,8 @@ do_compile() {
>
> # Note: disabled for now, since docker is launching containerd
> # inherit systemd
> -# SYSTEMD_PACKAGES = "${@bb.utils.contains('DISTRO_FEATURES','systemd','${PN}','',d)}"
> -# SYSTEMD_SERVICE_${PN} = "${@bb.utils.contains('DISTRO_FEATURES','systemd','containerd.service','',d)}"
> +# SYSTEMD_PACKAGES = "${PN}"
> +# SYSTEMD_SERVICE_${PN} = "containerd.service"
>
> do_install() {
> mkdir -p ${D}/${bindir}
> --
> 2.11.0
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
More information about the meta-virtualization
mailing list