[meta-virtualization] [PATCH] linux-yocto: Fix systemd-modules-load.service start failure

[Mark Asselstine]

On Fri, Jul 27, 2018 at 9:42 AM, He Zhe <zhe.he at windriver.com> wrote:
>
>
> On 2018年07月26日 23:30, Mark Asselstine wrote:
>> On Thu, Jul 26, 2018 at 10:41 AM, Bruce Ashfield
>> <bruce.ashfield at gmail.com> wrote:
>>> merged.
>>>
>>> Bruce
>>>
>>> On Tue, Jul 24, 2018 at 7:08 AM, He Zhe <zhe.he at windriver.com> wrote:
>>>> systemd-modules-load.service bindly load whatever in modules-load.d/*.conf,
>>>> in this case, kvm_intel and kvm_amd. One of them must fail on a specific
>>>> board and causes the following failure.
>>>>
>>>> This patches remove them from KERNEL_MODULE_AUTOLOAD and leaves them to udev.
>>>>
>>>> systemd-modules-load.service: Main process exited, code=exited, status=1/FAILURE
>>>> Failed to start Load Kernel Modules.
>> Nice. I have been wanting to look at why this message was being produced.
>>
>> I do wonder if this change will cause an issue for folks using
>> meta-virtualization with sysvinit though. What is the behavior if this
>> is the case?
>
> It's also OK for sysvinit.
>
> With sysvinit, modutils.sh in modutils-initscripts.bb in packagegroup-core-boot.bb
> would take care of /etc/modules-load.d. And udev still takes care of kvm-intel and
> kvm-amd.

Great. Thanks for checking.

Mark

>
> Zhe
>
>>
>> Mark
>>
>>>> Signed-off-by: He Zhe <zhe.he at windriver.com>
>>>> ---
>>>>  recipes-kernel/linux/linux-yocto_virtualization.inc | 2 --
>>>>  1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/recipes-kernel/linux/linux-yocto_virtualization.inc b/recipes-kernel/linux/linux-yocto_virtualization.inc
>>>> index 9905ed9..c09b07c 100644
>>>> --- a/recipes-kernel/linux/linux-yocto_virtualization.inc
>>>> +++ b/recipes-kernel/linux/linux-yocto_virtualization.inc
>>>> @@ -10,8 +10,6 @@ KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'featu
>>>>
>>>>  KERNEL_MODULE_AUTOLOAD += "openvswitch"
>>>>  KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm', '', d)}"
>>>> -KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-amd', '', d)}"
>>>> -KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-intel', '', d)}"
>>>>
>>>>  # aufs kernel support required for xen-image-minimal
>>>>  KERNEL_FEATURES_append += "${@bb.utils.contains('DISTRO_FEATURES', 'aufs', ' features/aufs/aufs-enable.scc', '', d)}"
>>>> --
>>>> 2.11.0
>>>>
>>>
>>>
>>> --
>>> "Thou shalt not follow the NULL pointer, for chaos and madness await
>>> thee at its end"
>>> --
>>> _______________________________________________
>>> meta-virtualization mailing list
>>> meta-virtualization at yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization