[meta-virtualization] [PATCH] vgabios: don't override the compiler ldflags

[Dariusz Pelowski]

Hi,

When building biossums on genericx86-64 machine, I'm getting QA issue:
ERROR: biossums-0.7a-r0 do_package_qa: QA Issue: No GNU_HASH in the elf
binary:
'/home/darekp/yocto_builds/tmp/work/core2-64-poky-linux/biossums/0.7a-r0/packages-split/biossums/usr/bin/biossums'
[ldflags]
ERROR: biossums-0.7a-r0 do_package_qa: QA run found fatal errors. Please
consider fixing them.
ERROR: biossums-0.7a-r0 do_package_qa: Function failed: do_package_qa
ERROR: Logfile of failure stored in:
/home/darekp/yocto_builds/tmp/work/core2-64-poky-linux/biossums/0.7a-r0/temp/log.do_package_qa.19574
ERROR: Task
(/home/darekp/yocto_builds/meta-virtualization/recipes-extended/vgabios/biossums_0.7a.bb:do_package_qa)
failed with exit code '1'

It's caused by overriding LDFLAGS variable to empty value in project's
makefile. In consequence there's missing LDFLAGS settings from bitbake
(including -Wl,--hash-style=gnu, which causes showing this QA).

This patch takes into the use LDFLAGS provided by bitbake.

Is it okay for you? What do you think about replacing sed invocations with
patch?

Dariusz


2017-10-17 19:12 GMT+02:00 Bruce Ashfield <bruce.ashfield at gmail.com>:

> This needs a long log.
>
> What issue are you fixing ? What arches is that issue showing up on, etc.
>
> Bruce
>
> On Tue, Oct 17, 2017 at 12:13 PM, Dariusz Pelowski
> <dariusz.pelowski at gmail.com> wrote:
> > ---
> >  recipes-extended/vgabios/biossums_0.7a.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/recipes-extended/vgabios/biossums_0.7a.bb
> b/recipes-extended/vgabios/biossums_0.7a.bb
> > index 10bd014..e66bade 100644
> > --- a/recipes-extended/vgabios/biossums_0.7a.bb
> > +++ b/recipes-extended/vgabios/biossums_0.7a.bb
> > @@ -20,6 +20,7 @@ do_configure() {
> >      # Don't override the compiler or its flags:
> >      sed 's,^CC,DISABLED_CC,' -i Makefile
> >      sed 's,^CFLAGS,DISABLED_CFLAGS,' -i Makefile
> > +    sed 's,^LDFLAGS,DISABLED_LDFLAGS,' -i Makefile
> >      # Supply the C flags to the compiler:
> >      sed 's,-o biossums,$(CFLAGS) -o biossums,' -i Makefile
> >  }
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > meta-virtualization mailing list
> > meta-virtualization at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-virtualization
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-virtualization/attachments/20171017/291857a6/attachment.html>