[meta-virtualization] [PATCH] runc-docker_git: use SRCREV instead of SRCREV_runc-docker

Ricardo Salveti ricardo at opensourcefoundries.com
Mon Oct 16 18:07:41 PDT 2017


On Mon, Oct 16, 2017 at 11:01 PM, Bruce Ashfield
<bruce.ashfield at gmail.com> wrote:
> On Mon, Oct 16, 2017 at 8:50 PM, Bruce Ashfield
> <bruce.ashfield at gmail.com> wrote:
>> On Mon, Oct 16, 2017 at 5:17 PM, Ricardo Salveti
>> <ricardo at opensourcefoundries.com> wrote:
>>> runc.inc sets PV based on "${RUNC_VERSION}+git${SRCREV}", which is
>>> set correctly by runc-opencontainers but not by runc-docker (PV was set
>>> to 1.0.0-rc3+gitINVALID-r0 instead of using the SRCREV hash).
>>
>> Then I'll revert the .inc
>>
>> As I mentioned before, I'm keeping the named SRCREVs. I didn't notice that on
>> the way in.
>
> I see the issue. I won't take this patch, but will fix things up a
> different way.

Cool, I didn't know if the idea was to use named SRCREV, but handing
that differently in the .inc should also fix the problem.

Thanks!
-- 
Ricardo Salveti


More information about the meta-virtualization mailing list