[meta-virtualization] [RFC] xen: Enable compilation with external source

[Christopher Clark]

On Tue, Nov 21, 2017 at 12:07 PM, Bruce Ashfield
<bruce.ashfield at gmail.com> wrote:
>
> On Thu, Nov 16, 2017 at 5:41 PM, Alistair Francis
> <alistair.francis at xilinx.com> wrote:
>>
>> When building Xen from an external source the compile step fails as
>> there is no Makefile (or anything else) copied into the Yocto
>> build directories.
>
> I can't say that I have an opinion on this, since I'm not up to speed on all
> the moving parts.
>
> I haven't seen any replies from the Xen folks, so replying in the hopes that
> they'll see this and notice the thread.

Hello - thanks for the nudge.

> One question though. When you say 'external source' are you talking about
> the oe-core "externalsrc" concept, or some Xen specific thing ?

I've never used the externalsrc class, so this review is a bit tricky.

Alistair: There's a comment at the top of the externalsrc.bbclass file
that indicates that a second variable (EXTERNALSRC_BUILD_pn-myrecipe)
could be used to set the build directory to be the same as the source
directory -- does using that give the behaviour that you're looking
for, without needing this cp added to do_compile?

Christopher


>
> Bruce
>
>>
>>
>> Signed-off-by: Alistair Francis <alistair.francis at xilinx.com>
>> ---
>> This seems really nasty, but it's the only way I can get external
>> source build working.
>>
>>  recipes-extended/xen/xen.inc | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
>> index cb314f8..7a54416 100644
>> --- a/recipes-extended/xen/xen.inc
>> +++ b/recipes-extended/xen/xen.inc
>> @@ -901,7 +901,6 @@ EXTRA_OEMAKE += "XEN_CONFIG_EXPERT=y"
>>  EXTRA_OEMAKE += "debug=n"
>>
>>  do_configure() {
>> -
>>      #./configure --enable-xsmpolicy does not set XSM_ENABLE must be done
>> manually
>>      if [ "${XSM_ENABLED}" = "1" ]; then
>>          echo "XSM_ENABLE := y" > ${S}/.config
>> @@ -920,6 +919,9 @@ do_configure() {
>>  }
>>
>>  do_compile() {
>> +    # If using external source we need to copy the code in
>> +    cp -rf ${S}/* ${B}/
>> +
>>      # workaround for build bug when CFLAGS is exported
>>      # https://www.mail-archive.com/xen-devel@lists.xen.org/msg67822.html
>>      unset CFLAGS
>> --
>> 2.14.1
>>
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization at yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee at
> its end"
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>