[meta-virtualization] [[PATCH 4/6] protobuf-native: Enable shared libs

[Bruce Ashfield]

On Tue, Mar 21, 2017 at 10:14 AM, Bruce Ashfield <bruce.ashfield at gmail.com>
wrote:

>
>
> On Tue, Mar 21, 2017 at 9:55 AM, Khem Raj <raj.khem at gmail.com> wrote:
>
>>
>>
>> On Tue, Mar 21, 2017 at 5:17 AM Bruce Ashfield <bruce.ashfield at gmail.com>
>> wrote:
>>
>>> On Mon, Mar 20, 2017 at 11:59 PM, Khem Raj <raj.khem at gmail.com> wrote:
>>>
>>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>>> ---
>>>  recipes-devtools/protobuf/protobuf-native_3.1.0.bb | 4 +---
>>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/recipes-devtools/protobuf/protobuf-native_3.1.0.bb
>>> b/recipes-devtools/protobuf/protobuf-native_3.1.0.bb
>>> index 47fb401..c32f627 100644
>>> --- a/recipes-devtools/protobuf/protobuf-native_3.1.0.bb
>>> +++ b/recipes-devtools/protobuf/protobuf-native_3.1.0.bb
>>> @@ -8,14 +8,12 @@ LICENSE = "BSD-3-Clause"
>>>
>>>  LIC_FILES_CHKSUM = "file://LICENSE;md5=35953c752e
>>> fc9299b184f91bef540095"
>>>
>>> -PR = "r0"
>>>
>>>
>>> This is mixing changes. Either put it in the commit log, or split the
>>> change. Either
>>> way works for me.
>>>
>>
>> This is virtually a nop
>>
>
> I'm aware, but that's not the point.
>
> Proper commit log standards are don't mix changes. It's trivial to add it
> in the log or split the change.
>
>
>>
>>> We also have no justification as to why we actually want shared libs ?
>>> I'd like
>>> to understand why, since someone will eventually ask me :D
>>>
>>
>> Protobuf-c needs the shared libraries to build
>>
>
> So that belongs in the log, along with the error message. Otherwise, we
> are just creating
> an unmaintainable jumble of crap.
>

.. and if you just send me the details, I can always add it and do the
split myself. I've just
never seen this in my builds, so I don't have it to add.

Bruce


>
> Bruce
>
>
>>
>>> Bruce
>>>
>>>
>>> -
>>>  SRC_URI[md5sum] = "14a532a7538551d5def317bfca41dace"
>>>  SRC_URI[sha256sum] = "0a0ae63cbffc274efb573bdde9a25
>>> 3e3f32e458c41261df51c5dbc5ad541e8f7"
>>>  SRC_URI = "https://github.com/google/protobuf/archive/v3.1.0.tar.gz;
>>> downloadfilename=protobuf-3.1.0.tar.gz \
>>>         "
>>>
>>> -EXTRA_OECONF += " --with-protoc=echo --disable-shared"
>>> +EXTRA_OECONF += " --with-protoc=echo"
>>>
>>>  inherit native autotools
>>>
>>> --
>>> 2.12.0
>>>
>>>
>>>
>>>
>>> --
>>> "Thou shalt not follow the NULL pointer, for chaos and madness await
>>> thee at its end"
>>>
>>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end"
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-virtualization/attachments/20170321/6380c037/attachment-0001.html>