[meta-virtualization] [PATCH] docker: downgrade lxc/docker-registry/rt-tests to suggests

[Bruce Ashfield]

On 2017-02-09 09:52 AM, Fathi Boudra wrote:
> On 9 February 2017 at 15:56, Bruce Ashfield
> <bruce.ashfield at windriver.com> wrote:
>> On 2017-02-09 02:25 AM, Fathi Boudra wrote:
>>>
>>> Regular users don't need lxc, docker-registry and rt-tests on the target.
>>> These tools aren't even needed or provide additional features when running
>>> docker at runtime. They also increase the size of the image uneccessarily.
>>
>>
>> They can also just inhibit the installation of rrecommends (which is
>> what I do).
>>
>> But yes, I'm ok with making sure that these aren't slipping into more
>> builds than necessary.
>
> yes, that's what I thought too but I think it's worth fixing to avoid
> everybody using docker to fallback using BAD_RECOMMENDATIONS,
> NO_RECOMMENDATIONS or PACKAGE_EXCLUDE.

Agreed. It isn't obvious why lxc appears on the target when you
just want docker :D

This is now merged.

Bruce

>
>> Bruce
>>
>>
>>>
>>> Signed-off-by: Fathi Boudra <fathi.boudra at linaro.org>
>>> ---
>>>  recipes-containers/docker/docker_git.bb | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/recipes-containers/docker/docker_git.bb
>>> b/recipes-containers/docker/docker_git.bb
>>> index c208a02..81fd4d4 100644
>>> --- a/recipes-containers/docker/docker_git.bb
>>> +++ b/recipes-containers/docker/docker_git.bb
>>> @@ -61,8 +61,8 @@ RDEPENDS_${PN} = "curl aufs-util git util-linux iptables
>>> \
>>>
>>> ${@bb.utils.contains('DISTRO_FEATURES','systemd','','cgroup-lite',d)} \
>>>                   "
>>>  RDEPENDS_${PN} += "containerd runc"
>>> -RRECOMMENDS_${PN} = "lxc docker-registry rt-tests"
>>> -RRECOMMENDS_${PN} += " kernel-module-dm-thin-pool kernel-module-nf-nat"
>>> +RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat"
>>> +RSUGGESTS_${PN} = "lxc docker-registry rt-tests"
>>>  DOCKER_PKG="github.com/docker/docker"
>>>
>>>  do_configure[noexec] = "1"
>>>