[meta-virtualization] [PATCH 4/4] libvirt: Replace systemd units location to match with bitbake environment.

[Mark Asselstine]

On Wed, Feb 8, 2017 at 9:37 AM, avalluri <amarnath.valluri at intel.com> wrote:
>
>
> On 08.02.2017 16:15, Mark Asselstine wrote:
>
> On Wed, Feb 8, 2017 at 8:46 AM, Amarnath Valluri
> <amarnath.valluri at intel.com> wrote:
>
> Signed-off-by: Amarnath Valluri <amarnath.valluri at intel.com>
> ---
>  recipes-extended/libvirt/libvirt_1.3.5.bb | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/recipes-extended/libvirt/libvirt_1.3.5.bb
> b/recipes-extended/libvirt/libvirt_1.3.5.bb
> index c848c99..206f59f 100644
> --- a/recipes-extended/libvirt/libvirt_1.3.5.bb
> +++ b/recipes-extended/libvirt/libvirt_1.3.5.bb
> @@ -213,6 +213,12 @@ PACKAGECONFIG[wireshark] =
> "--with-wireshark-dissector,--without-wireshark-disse
>  # Enable the Python tool support
>  require libvirt-python.inc
>
> +do_configure_prepend() {
> +       systemd_system_unitdir="${@d.getVar('systemd_system_unitdir')}"
> +       sed -i -e "s;^SYSTEMD_UNIT_DIR =.*;SYSTEMD_UNIT_DIR =
> $systemd_system_unitdir;" \
> +            ${S}/daemon/Makefile.am ${S}/src/Makefile.am
> ${S}/tools/Makefile.am
>
> The others patches look fine but for this one is there no way to pass
> the value to make? I almost prefer to have this taken care of via a
> patch to the source instead of sed expressions here.
>
> Its value is hard coded in Makefile.am, one thing we can do is to patch the
> configure.ac to make systemd unit dir configurable from outside. I can send
> the V2 with this change.

I prefer that approach. Looking forward to the v2.

Mark

>
> -Amarnath
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>