[meta-virtualization] [PATCH] go-distribution-digest: Fix do_package failure

Bruce Ashfield bruce.ashfield at gmail.com
Wed Sep 7 13:07:51 PDT 2016


merged.

Bruce

On Tue, Sep 6, 2016 at 12:33 PM, Jason Wessel <jason.wessel at windriver.com>
wrote:

> The rule in the recipe which deletes all but LICENSE and the digest
> directory is broken depending on what ascii table bash uses by
> default for matching, specifically:
>
>     rm -rf ${S}/[A-KM-Za-ce-z]* ${S}/doc*
>
> The "A-K" piece will actually match both upper and lower case when the
> acsii because the ascii value is checked as being between two numbers:
>    0x41=a, 0x42=A,0x43=b...0x48=D
>
> This is contray to what you would typically think should work with the
> lower and uppers separated into two contiguous spaces.  To fix this,
> instead of using the "rm" logic, we can copy the components we need
> instead.
>
> Signed-off-by: Jason Wessel <jason.wessel at windriver.com>
> ---
>  recipes-devtools/go/go-distribution-digest_git.bb | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/recipes-devtools/go/go-distribution-digest_git.bb
> b/recipes-devtools/go/go-distribution-digest_git.bb
> index 31d724c..2a803da 100644
> --- a/recipes-devtools/go/go-distribution-digest_git.bb
> +++ b/recipes-devtools/go/go-distribution-digest_git.bb
> @@ -13,15 +13,13 @@ SRCREV = "d957768537c5af40e4f4cd96871f7b2bde9e2923"
>
>  S = "${WORKDIR}/git"
>
> -do_unpackpost() {
> -       rm -rf ${S}/[A-KM-Za-ce-z]* ${S}/doc*
> +# NO-OP the do compile rule because this recipe is source only.
> +do_compile() {
>  }
>
> -addtask unpackpost after do_unpack before do_patch
> -
>  do_install() {
>         install -d ${D}${prefix}/local/go/src/${PKG_NAME}
> -       cp -r ${S}/* ${D}${prefix}/local/go/src/${PKG_NAME}/
> +       cp -r ${S}/LICENSE ${S}/digest ${D}${prefix}/local/go/src/${
> PKG_NAME}/
>  }
>
>  SYSROOT_PREPROCESS_FUNCS += "go_distribution_digeset_sysroot_preprocess"
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-virtualization/attachments/20160907/fa2d2465/attachment.html>


More information about the meta-virtualization mailing list