[meta-virtualization] [PATCH] xen-image-minimal: if DISTRO_FEATURES is missing xen error

[Bruce Ashfield]

On Fri, Dec 16, 2016 at 12:27 PM, Doug Goldstein <cardoe at cardoe.com> wrote:

> On 1/22/16 10:57 PM, Doug Goldstein wrote:
> > It can be confusing to users why things are failing with missing kernel
> > dependencies when you don't have 'xen' in your DISTRO_FEATURES. This
> > should provide them with some better info.
> >
> > Signed-off-by: Doug Goldstein <cardoe at cardoe.com>
> > ---
> >
> > The result of this change is the following output:
> >
> > | DEBUG: Executing shell function do_check_xen_state
> > | ERROR: DISTRO_FEATURES does not contain 'xen'
> > | WARNING: exit code 1 from a shell command.
> >
> > ---
> >  recipes-extended/images/xen-image-minimal.bb | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/recipes-extended/images/xen-image-minimal.bb
> b/recipes-extended/images/xen-image-minimal.bb
> > index 26b6d06..b8c2002 100644
> > --- a/recipes-extended/images/xen-image-minimal.bb
> > +++ b/recipes-extended/images/xen-image-minimal.bb
> > @@ -20,6 +20,14 @@ LICENSE = "MIT"
> >
> >  inherit core-image
> >
> > +do_check_xen_state() {
> > +    if [ "${@bb.utils.contains('DISTRO_FEATURES', 'xen', ' yes', 'no',
> d)}" = "no" ]; then
> > +        die "DISTRO_FEATURES does not contain 'xen'"
> > +    fi
> > +}
> > +
> > +addtask check_xen_state before do_rootfs
> > +
> >  syslinux_iso_populate_append() {
> >       install -m 0444 ${STAGING_DATADIR}/syslinux/libcom32.c32
> ${ISODIR}${ISOLINUXDIR}
> >       install -m 0444 ${STAGING_DATADIR}/syslinux/mboot.c32
> ${ISODIR}${ISOLINUXDIR}
> >
>
> Ping? This would have solved Andrew Stuart's thread from 11/11/16.
>

Yep, looks fine .. again, I'm not sure how this was missed. I'll merge it
shortly.

Bruce


>
> --
> Doug Goldstein
>
>


-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-virtualization/attachments/20161218/14f498dd/attachment.html>