[meta-virtualization] [meta-cloud-services][fido-kilo][PATCH 41/42] packagegroup-cloud-extras: include xterm only if x11 in DISTRO_FEATURES

[Mark Asselstine]

On December 9, 2015 08:44:14 AM Josep Puigdemont wrote:
> On Tue, Dec 08, 2015 at 08:31:53PM -0500, Mark Asselstine wrote:
> > On Tue, Dec 8, 2015 at 12:33 PM, Josep Puigdemont
> > 
> > <josep.puigdemont at enea.com> wrote:
> > > Signed-off-by: Josep Puigdemont <josep.puigdemont at enea.com>
> > > ---
> > 
> > The reason we included xterm is to have the 'resize' command
> > available. Admittedly this is a big hammer to solve a small problem
> > but an annoying problem. Was xterm causing issues?
> 
> I had no x11 on one of my images, so the build bailed out due to that.

Alright. No objections then from me. Thanks for the follow up.

Mark

> 
> /Josep
> 
> > Mark
> > 
> > >  .../recipes-extended/packagegroups/packagegroup-cloud-extras.bb        
> > >  | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git
> > > a/meta-openstack/recipes-extended/packagegroups/packagegroup-cloud-extr
> > > as.bb
> > > b/meta-openstack/recipes-extended/packagegroups/packagegroup-cloud-extr
> > > as.bb index 35b9b6e..721e2c9 100644
> > > ---
> > > a/meta-openstack/recipes-extended/packagegroups/packagegroup-cloud-extr
> > > as.bb +++
> > > b/meta-openstack/recipes-extended/packagegroups/packagegroup-cloud-extr
> > > as.bb @@ -8,7 +8,7 @@ inherit packagegroup
> > > 
> > >  RDEPENDS_${PN} = " \
> > >  
> > >      vim \
> > > 
> > > -    xterm \
> > > +    ${@base_contains('DISTRO_FEATURES', 'x11', 'xterm', '', d)} \
> > > 
> > >      "
> > >  
> > >  IMAGE_FEATURES += "package-management"
> > > 
> > > --
> > > 2.5.0
> > > 
> > > --
> > > _______________________________________________
> > > meta-virtualization mailing list
> > > meta-virtualization at yoctoproject.org
> > > https://lists.yoctoproject.org/listinfo/meta-virtualization